Skip to content

fix(settings): open the settings window from Cmd-comma and links #3424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datlechin merged 1 commit into from
Oct 15, 2026
Merged

fix(settings): open the settings window from Cmd-comma and links #3424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion TablePro/Views/Settings/SettingsWindowController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ internal final class SettingsWindowController: NSWindowController {
contentViewController as? SettingsPaneTabViewController
}

internal convenience init(registryClient: RegistryClient = .shared) {
// A defaulted parameter would let `SettingsWindowController()` resolve to the inherited `init()`, which builds no window.
internal convenience init() {
self.init(registryClient: .shared)
}

internal convenience init(registryClient: RegistryClient) {
let panes = SettingsPaneTabViewController(registryClient: registryClient)

/// `NSWindow(contentViewController:)` binds the window title to the content view
Expand Down
12 changes: 12 additions & 0 deletions TableProTests/Views/Settings/SettingsWindowTitleTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,4 +124,16 @@ final class SettingsWindowTitleTests: XCTestCase {

XCTAssertEqual(window.contentMinSize, SettingsPaneTabViewController.paneSize)
}

func testTheInitializerPresentUsesBuildsTheSettingsWindow() {
AppStorageEnvironment.shared.defaults.set(
SettingsPane.general.rawValue,
forKey: PreferenceKeys.selectedSettingsPane.name
)
let controller = SettingsWindowController()
guard let window = controller.window else { return XCTFail("Cmd-comma and settings links present this controller") }
windows.append(window)

XCTAssertEqual(window.identifier?.rawValue, WindowIdentifier.settings)
}
}
Loading