Skip to content

fix(settings): open the settings window from Cmd-comma and links - #3424

Merged
datlechin merged 1 commit into
mainfrom
fix/settings-window-init
Oct 15, 2026
Merged

datlechin merged 1 commit into
mainfrom
fix/settings-window-init

Conversation

@datlechin

Copy link
Copy Markdown
Member

Why

Change

  • An explicit init() delegates to init(registryClient: .shared); the registry parameter has no default, so the call can't fall through again.

Verified

  • New SettingsWindowTitleTests.testTheInitializerPresentUsesBuildsTheSettingsWindow builds the controller the way present does and fails on main (no window). Reproduced locally: with the settings URL, main's build opens no window at all.

@datlechin
datlechin merged commit 342d5a6 into main Oct 15, 2026
7 checks passed
@datlechin
datlechin deleted the fix/settings-window-init branch October 15, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant