Repository navigation
fix(settings): open the settings window from Cmd-comma and links - #3424
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
tablepro://settingslinks do nothing. 5 UI flows fail on it.SettingsWindowController'sinit()withinit(registryClient: RegistryClient = .shared).presentstill callsSettingsWindowController(), which now resolves to the inheritedinit()and builds a controller with no window.Change
init()delegates toinit(registryClient: .shared); the registry parameter has no default, so the call can't fall through again.Verified
SettingsWindowTitleTests.testTheInitializerPresentUsesBuildsTheSettingsWindowbuilds the controller the waypresentdoes and fails on main (no window). Reproduced locally: with the settings URL, main's build opens no window at all.