Skip to content

feat(settings): theme every content surface and the window backdrop - #3406

Merged
datlechin merged 5 commits into
mainfrom
refactor/theme-whole-app
Oct 13, 2026
Merged

datlechin merged 5 commits into
mainfrom
refactor/theme-whole-app

Conversation

@datlechin

@datlechin datlechin commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Why

A theme stopped at the editor and the grid. Under Dracula or Nord, trees, diffs, diagrams, value viewers and the window around them stayed system gray.

Change

  • Every content view takes the theme: JSON and PHP trees, value and hex viewers, inspector fields, diffs, ER and query plan diagrams, charts, result states, and code fields inside forms and sheets.
  • New window.background slot. On macOS 26 and later it sets the window background, and the sidebar, inspector and toolbar glass take it on. Chrome, controls, accent and Settings are never painted.
  • Default Light and Dark draw what they drew before, except tree values now use the syntax colors and the result bar drops its dot separator.
  • Triggers and ClickHouse Parts are data grids, like Columns.

Verified

Each themed surface has a test that its default matches main and that it follows an override. Guard suites fail any theme read or window color outside the listed files. Default screenshots match main pixel for pixel apart from the dropped dot.

Screenshots

Dracula Before After
Main window Before Dracula After Dracula

Nord: After Nord

Structure under Dracula: After Structure Dracula

Default Dark, unchanged: After Dark

Not in this PR

@datlechin
datlechin merged commit 122e443 into main Oct 13, 2026
12 checks passed
@datlechin
datlechin deleted the refactor/theme-whole-app branch October 13, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant