Repository navigation
feat(settings): theme every content surface and the window backdrop - #3406
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A theme stopped at the editor and the grid. Under Dracula or Nord, trees, diffs, diagrams, value viewers and the window around them stayed system gray.
Change
window.backgroundslot. On macOS 26 and later it sets the window background, and the sidebar, inspector and toolbar glass take it on. Chrome, controls, accent and Settings are never painted.Verified
Each themed surface has a test that its default matches main and that it follows an override. Guard suites fail any theme read or window color outside the listed files. Default screenshots match main pixel for pixel apart from the dropped dot.
Screenshots
Nord:
Structure under Dracula:
Default Dark, unchanged:
Not in this PR