Repository navigation
fix(datagrid): restore spoken labels and minimums on structure grids - #3408
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-ups to #3406. Moving Triggers and ClickHouse Parts onto the data grid made VoiceOver read the Enabled and Active columns as YES or NO, and dropped the old per-column minimum widths. The DynamoDB maintenance preview, an API call with a JSON body, was highlighted as SQL, and the filter preview ignored the connection's engine.
Change
Verified
New tests read the cells through the accessibility API, apply the minimums through the column pool, and check the preview language per engine.