Repository navigation
refactor(settings)!: draw default themes in macOS system colors - #3395
Merged
Merged
Conversation
…-rewrite # Conflicts: # TablePro/Resources/Localizable.xcstrings
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After #2791 the app stopped looking like macOS. A wrapper recolored the text in every content pane, the default themes used fixed hex for the editor and status colors, the grid painted its selection as a 28% wash under white text, and baked colors ignored Accent, Highlight and Increase Contrast. Every theme had to declare all 43 slots, so "default = native" could not be expressed.
Change
Verified
Source-scan guards fail on any theme read, literal color or hidden pane background outside the allowed files. A default-theme selected row matches a stock
NSTableRowViewpixel for pixel. A UI test drives create, rename, reset and delete.Screenshots
Dracula colors only the editor and the grid:
Not in this PR
TreeSitterClient.quickHighlightcolors them as numbers.UITestCaseclears it from inside the runner's sandbox container, so it never reaches the app'scom.TablePro.uitestsuite.