Repository navigation
refactor: validate editor zoom outside the menu validation hub - #3396
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Repo Hygiene fails on main since #3395. Its zoom dimming added two
MenuValidationContextfields and acase #selectorarm, which the hub ratchet refuses.Change
validateMenuItemfrom the live typography setting, throughMainSplitViewController.zoomEnablement(_:typography:)beside the zoom actions. The size is the app's, not the window's, so it never belonged in the captured context.canZoomInandcanZoomOutfrom the context and the old zoom arm fromresolvedEnablement.Verified
EditorZoomTests,MenuValidationCoverageTestsandMenuContentModeParityTestspass.check-hub-ratchet.pypasses.