Repository navigation
refactor(settings)!: remove the per-kind notification toggles - #3386
Merged
Merged
Conversation
…ication-kind-toggles # Conflicts: # CHANGELOG.md # TablePro/Models/Settings/NotificationSettings.swift
…ication-kind-toggles
…ication-kind-toggles
…r-side-export' into refactor/remove-notification-kind-toggles
…ication-kind-toggles
Signed-off-by: Dat Ngo Quoc <datlechin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Settings > Notifications listed 11 per-kind toggles under the master switch. No issue asks for per-kind control, and the threshold plus the on-screen check already filter the noise.
Change
Verified
Not in this PR
TableProTestscompiles on currentmain; that diff drops out once test(coordinator): fix the chrome snapshot build and re-record it #3389 merges.