Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions internal/tui/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package tui

import (
"os"
"path/filepath"
"runtime"
"testing"
)
Expand Down Expand Up @@ -178,6 +179,43 @@ func TestLoadSavedConfigMissing(t *testing.T) {
}
}

func TestLoadSavedConfigCorrupt(t *testing.T) {
for name, data := range map[string]string{
"truncated": `{"domain":`,
"invalid field type": `{"domain":"saved.example.com","concurrency":"many"}`,
} {
t.Run(name, func(t *testing.T) {
redirectConfig(t)
p, err := configPath()
if err != nil {
t.Fatal(err)
}
if err := os.MkdirAll(filepath.Dir(p), 0o700); err != nil {
t.Fatal(err)
}
if err := os.WriteFile(p, []byte(data), 0o600); err != nil {
t.Fatal(err)
}
if sc, ok := loadSavedConfig(); ok || sc != (savedConfig{}) {
t.Fatalf("loadSavedConfig = %+v, %v; want empty config, false", sc, ok)
}
m := New(Options{})
if m.state != stateForm {
t.Fatalf("startup state = %v, want form", m.state)
}
defaults := newFormModel(savedConfig{})
for f, spec := range formFields {
if got, want := m.form.inputs[f].Value(), defaults.inputs[f].Value(); got != want {
t.Errorf("%s = %q, want default %q", spec.name(), got, want)
}
if m.form.toggles[f] != defaults.toggles[f] {
t.Errorf("%s = %v, want default %v", spec.name(), m.form.toggles[f], defaults.toggles[f])
}
}
})
}
}

// TestSavedConfigSeedsForm verifies a saved config drives the form defaults,
// which is what the `r` (new scan) keybind and startup rely on.
func TestSavedConfigSeedsForm(t *testing.T) {
Expand Down
49 changes: 49 additions & 0 deletions internal/tui/config_unix_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
//go:build unix

package tui

import (
"os"
"path/filepath"
"syscall"
"testing"
)

// The saved form can contain private file paths and resolver settings. Even a
// permissive umask must not make it readable by other users (#413).
func TestSaveConfigPrivatePermissions(t *testing.T) {
// Umask is process-wide: keep this test and its subtests non-parallel.
old := syscall.Umask(0)
defer syscall.Umask(old)
for _, existing := range []bool{false, true} {
name := "new"
if existing {
name = "replace"
}
t.Run(name, func(t *testing.T) {
redirectConfig(t)
p, err := configPath()
if err != nil {
t.Fatal(err)
}
if existing {
if err := os.MkdirAll(filepath.Dir(p), 0o700); err != nil {
t.Fatal(err)
}
if err := os.WriteFile(p, []byte("{}"), 0o666); err != nil {
t.Fatal(err)
}
}
if err := saveConfig(savedConfig{Domain: "example.com"}); err != nil {
t.Fatal(err)
}
info, err := os.Stat(p)
if err != nil {
t.Fatal(err)
}
if got := info.Mode().Perm(); got != 0o600 {
t.Errorf("last.json mode = %04o with umask 000, want 0600", got)
}
})
}
}
Loading