Repository navigation
test(tui): cover saved config privacy and corrupt fallback - #430
Merged
TMHSDigital merged 1 commit intoNov 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add regression coverage for the saved TUI form's privacy and corrupt-file fallback. On Unix, saving with umask 000 must create a 0600 file, including when replacing an existing 0666 file. The umask is restored after the non-parallel test.
Truncated JSON and a valid JSON object with an invalid field type must return an empty config with
ok=false.New()must still start on the form with every field and toggle at its default. The second case also guards against retaining a partially decoded domain.Related Issue
Fixes #413.
Type of Change
Checklist
Ethical Considerations
Additional Information
Validated on macOS arm64 with Go 1.26.11 and golangci-lint 2.15.0:
go test ./internal/tui/ -run Config -count=1passes.go test -race -shuffle=on ./...passes the full suite.make lintreports 0 issues;make build, gofmt, andgit diff --checkpass. The installed Command Line Tools make was used because the selected Xcode make launcher requires license acceptance.Tests use temporary configuration directories and local fixtures only. Prepared with OpenAI Codex assistance.