Repository navigation
Check the session before spending focus and refuse an old TLibs - #17
Merged
Merged
Conversation
A confirmed experiment spent focus and only then re-checked the menu's session, so a failed re-check lost the focus with no progress. The click handler already checks the session before anything runs, and spending focus cannot end a session, so the late re-check is gone. Research now disables itself at startup with a clear message when TLibs is older than 2.3.0, instead of staying enabled without its listeners. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
the
size:S
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to The startup and experiment-confirmation changes have no established merge-blocking issue. Normal checks remain appropriate before merging.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirming an experiment spent focus and only then re-checked the menu's character session. If that re-check failed, the focus was gone and the experiment made no progress, and a test locked that in. The click handler already checks the session before any action runs, and spending focus cannot end a session, so the late re-check is removed. The test now covers the real case: a menu whose session has ended cannot spend focus or progress the project.
Research also had no TLibs version check. With a TLibs older than 2.3.0 its listeners failed to register and the plugin stayed enabled doing nothing. It now logs "Research requires TLibs 2.3.0 or newer" and disables itself at startup, matching Infestations and Surgery, and skips its disable-time unload when it never started.
mvn clean verifypasses: 259 tests, coverage gate met.Docs: TF-Minecraft/Docs#171
🤖 Generated with Claude Code