Repository navigation
fix: reopen guild house tables after a restart - #41
Conversation
SimpleFactions and RPCharacters soft depend on each other, so Paper can enable Games before SimpleFactions. Tables loaded then read every guild cap as zero, count as over cap, and stay closed until someone touches them. Ready every idle table again once the server has loaded, and again if SimpleFactions enables late. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to The change adds refreshes at server load and SimpleFactions enable. A missed guild lookup could leave a table closed, but that startup condition is unconfirmed and no actionable failure is established.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
Guild-owned auto-dealer blackjack tables (RA&T at FIG casino, The_Bog) come back closed after every restart and do not say OPEN until someone interacts with them.
On TFMCMain, Games enables before SimpleFactions (
06:10:29vs06:10:30in today's log). SimpleFactions and RPCharacters soft depend on each other, so Paper's load order is not guaranteed. WhenloadAllreadies each table,GuildTables.capreads 0 because SimpleFactions is not enabled yet, so every guild table counts as over its cap (frozen) andprepareIdlecloses it. Nothing readied them again afterwards.Fix
TableManagerreadies every idle table again onServerLoadEvent, and again onPluginEnableEventfor SimpleFactions in case it enables late. This reuses the existingrefreshGuildAutoIdleloop, now generalised intorefreshIdle.Testing
🤖 Generated with Claude Code