Repository navigation
packages/core: publish as @superinstance/quilt-core, and ship dist/ - #40
Merged
Merged
Conversation
The @quilt npm scope belongs to quiltdata, so @quilt/core could never be published by us -- and every package in the family that depends on it fails to install with: npm error 404 @quilt/core@* is not in this registry. Also adds a files field. There was none, so npm fell back to .gitignore, which lists dist/ -- the tarball shipped src/ without the build, and main named a file that was not in the package. That is the same defect as the one fixed in Motifcode4quilt today, and it is why 0.3.0 was published broken and deprecated in the same hour.
…import PR #40 renamed packages/core only. That leaves the monorepo internally inconsistent and the SDK broken once published, so this completes the scope across every package that names it. Manifests: - core -> @superinstance/quilt-core 0.3.4 - sdk -> @superinstance/quilt-sdk 0.2.7 - cli/mcp/tui/docs follow - every @quilt/* dependency spec repointed at @superinstance/* with real ranges (^0.3.3 etc), replacing '*' and file: links The root build script selects workspaces BY NAME (-w @quilt/core -w @quilt/sdk ...). Renaming the packages without touching it leaves npm run build building nothing, so it moves too. Schema import (TS2307 / ERR_MODULE_NOT_FOUND): src/index.ts reached the schema with '../../../schemas/manifest.schema.json' -- outside rootDir. It resolved in-tree, so the monorepo built green, and the emitted dist/index.js kept the same specifier. After publish, the tarball has no schemas/ dir, so the import resolved to node_modules/schemas/ -- outside the package -- and import() threw ERR_MODULE_NOT_FOUND. The schema now ships inside the SDK (src/schemas -> dist/schemas) and is covered by the existing files:[dist]. core's peerDependencies on @quilt/ai is dropped rather than repointed: core only documents an AIEngine subset in comments and never imports it, so the peer was a claim on a package we cannot install. Verified on this branch: npm install -> exit 0 npm run build -> exit 0 (all 5 workspaces) npm test -> exit 0 (core 8 files, sdk 79/79, tui 15/15) published-tarball sim -> import() OK, 23 exports, manifestSchema resolves sdk@0.2.7 in a publish-shaped copy outside the monorepo, installed against PUBLISHED @superinstance/quilt-core@0.3.3 -> npm test 79/79 pass Remaining, deliberately out of this rename PR: docs/ guides, landing/ marketing pages and RELEASE-*.md still say @quilt/*. Tracked in the PR body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scope, and why
@quilt/*is not a scope this fleet owns.npm view @quilt/coreis a 404 for every package in the family, so any repo depending on it cannot install:The root package has been republished as
@superinstance/quilt-core(0.3.3 is the first publish that is clean in registry metadata: no promoteddevDependencies, no dead-scope peer). This PR completes the rename across the whole monorepo.What changed
All six manifests move to the scope the fleet holds, and every
@quilt/*dependency spec becomes a real version range instead of*orfile::@quilt/core0.3.0@superinstance/quilt-core0.3.4@quilt/sdk0.2.0@superinstance/quilt-sdk0.2.7@quilt/{cli,mcp,tui,docs}@superinstance/quilt-{cli,mcp,tui,docs}The root
buildscript selects workspaces by name (-w @quilt/core -w @quilt/sdk ...). Renaming the packages without touching it leavesnpm run buildbuilding nothing, so it moves too. This was not in the brief and would have broken CI silently.core'speerDependencieson@quilt/aiis dropped, not repointed: core only documents anAIEnginesubset in comments and never imports it, so the peer was a claim on a package we cannot install.The schema import (TS2307 / ERR_MODULE_NOT_FOUND)
packages/sdk/src/index.tsreached the schema with../../../schemas/manifest.schema.json— outsiderootDir. It resolved in-tree, so the monorepo built green, and the emitteddist/index.jskept the same specifier. After publish the tarball has noschemas/dir, so the import resolved tonode_modules/schemas/— outside the package — and threw:The schema now ships inside the SDK (
src/schemas/->dist/schemas/), covered by the existingfiles: ["dist"].Verified on this branch
Deliberately out of scope
docs/guides,landing/marketing pages,RELEASE-*.mdandquilt_worker/quilt_core/*still say@quilt/*. They are prose and vendored build output, not a package boundary; folding them in would bury the rename. Flagged as follow-up doc debt.Not merged. Left for review.