Repository navigation
Rename to @superinstance/quilt-evolve and replace workspace:* with a real version range - #3
Open
SuperInstance wants to merge 3 commits into
Open
SuperInstance wants to merge 3 commits into
SuperInstance wants to merge 3 commits into
Conversation
…real range
Mirror of the quilt-ai change. Not a monorepo (no 'workspaces' field),
yet both deps used the npm workspace: protocol -- and they formed a
cycle with quilt-ai (evolve -> ai -> evolve).
BEFORE -- npm install:
npm error code EUNSUPPORTEDPROTOCOL
npm error Unsupported URL Type "workspace:": workspace:*
exit 1
AFTER -- npm install (fresh cache):
exit 0
@superinstance/quilt-core@0.3.3 (from the registry)
The cycle is broken at the same place as in quilt-ai: core is published
so it becomes a real dependency at ^0.3.3; @superinstance/quilt-ai is
not published, so that edge is an optional peer rather than a version
range that could only ETARGET. src/ only ever referenced @quilt/ai in a
doc comment ('a minimal AI engine interface ... compatible with
@quilt/ai'), so no runtime import needed retargeting.
KNOWN PRE-EXISTING FAILURE, not fixed here (a rename PR should contain
a rename). Install is fixed, but build and test still fail:
npm run build
tsconfig.json(16,25): error TS5108: Option 'moduleResolution=node10'
has been removed. Please remove it from your configuration.
exit 2
npm test
fails inside test/evolve.test.js at its execSync('npx tsc') build step,
same cause. exit 1
tsconfig.json is untouched by this branch, and 'moduleResolution': 'node'
with 'typescript': '^7.0.2' are both on main. TypeScript 7 removed the
node10 resolver, so this was already broken -- it was invisible only
because the install died first.
Verified out-of-band, in a scratch copy and NOT committed here:
setting moduleResolution to 'bundler' makes 'npm run build' exit 0 and
'npm test' pass 13/13. So the rename is complete and this tsconfig line
is the whole of what remains. It wants its own PR.
The TypeScript 7 census (research/TS7-CENSUS.md, a complete scan of 5,298
of 5,298 repos) measured this exact failure:
tsconfig.json(16,25): error TS5108: Option 'moduleResolution=node10'
has been removed.
and it also found that the fix had ALREADY landed on main, in commit
6734a96 ("un-break the build"). This branch was cut before that commit, so
it still carried the broken configuration -- which is why the PR's tests
were red for a reason that had nothing to do with the rename.
The fix is the same one, reapplied:
"module": "commonjs" -> "node16"
"moduleResolution": "node" -> "node16"
This package has no "type" field, so it is CommonJS and TypeScript infers
that.
Verified on this branch:
npm run lint clean
npm test 13/13 tests pass
The tsconfig fix landed but the test jobs did not run on the push. This commit exists only to make GitHub fire the pull_request event, so the rename's own gates (lint, security, both test legs) actually execute and the result is on the record rather than assumed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of SuperInstance/quilt-ai. Follows the same scope move as SuperInstance/quilt#40.
What was broken
@quilt/*is a scope this fleet does not own. Separately, this repo declaredworkspace:*dependencies while not being a monorepo (noworkspacesfield), and it formed a dependency cycle withquilt-ai(evolve -> ai -> evolve).Before
After
Version ranges, not workspace links
@superinstance/quilt-coreis published (0.3.3) -> real dependency^0.3.3.@superinstance/quilt-aiis not published yet and the two repos depend on each other, so that edge becomes an optional peerDependency: never auto-installed, install stays green, intent preserved.src/only ever referenced@quilt/aiin a doc comment ("a minimal AI engine interface ... compatible with @quilt/ai"), so no runtime import needed retargeting.Still failing, and it is not the scope
Install is fixed, but build and test hit a pre-existing bug this PR does not touch:
tsconfig.jsonis untouched by this branch, and"moduleResolution": "node"with"typescript": "^7.0.2"are both onmain. TypeScript 7 removed the node10 resolver. It was invisible only because the install died first.Verified out-of-band in a scratch copy (not committed here): setting
moduleResolutiontobundlermakesnpm run buildexit 0 andnpm testpass 13/13. So the rename is complete and this one tsconfig line is all that remains. It wants its own PR.Not merged. Left for review.