Repository navigation
Add a library target so hosts can embed the agent - #4
Merged
Merged
Conversation
Co-Authored-By: SplitFire v1.0.0-acp <noreply@splitfire.ai>
CI fmt fix and pre-commit hook. Co-Authored-By: SplitFire v1.0.0-acp <noreply@splitfire.ai>
src/lib.rs exposes the SplitFire profile (SplitFire, INFO, DEMUCS) and re-exports ed_acp, so an app can serve the agent in-process with ed_acp::serve instead of launching the binary. KaroKowe Jam does this to stay inside the App Store sandbox. The terminal UI and the MCP test stub move behind a default `cli` feature, and both binaries require it. A host builds with default-features = false and doesn't pull in ratatui and crossterm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![sigit-code-review[bot]](https://avatars.githubusercontent.com/in/3492899?s=60&v=4){kind=small}
There was a problem hiding this comment.
Adds a new library target exposing the SplitFire profile and re-exporting ed_acp for embedding the agent in-process. The CLI features (terminal UI and MCP stub) are moved behind a default "cli" feature, which is enabled by default to preserve existing behavior. The binaries require the "cli" feature. The library can be built with default-features = false to exclude CLI dependencies. src/lib.rs is added to expose the library API. src/main.rs is updated to use the library's exports. Cargo.toml is updated to define the "cli" feature and conditionally include binaries and dependencies.
Automated review by siGit Code Review · commit c98bdcf · see the review dashboard
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/lib.rsexposes the SplitFire profile (SplitFire,INFO,DEMUCS) and re-exportsed_acp. An app can then serve the agent in-process withed_acp::serveinstead of launching the binary. KaroKowe Jam uses this to stay inside the App Store sandbox (smbcloudXYZ/splitfire#33).The terminal UI and the MCP test stub move behind a default
clifeature, and both binaries require it.cargo installandcargo buildbehave as before. A host builds withdefault-features = falseand skips ratatui and crossterm.Tests:
cargo test(all suites pass), plus clippy with and without default features.The library only uses what ed-acp 1.1 already has. The host needs
ed_acp::servefrom ondeinference/ed#18 in ed-acp 1.2.