Repository navigation
Move embed's reqwest to 0.13, native-tls on watchOS - #15
Merged
Merged
Conversation
The optional reqwest dependency was 0.12 with rustls-tls-native-roots, which pulls in ring. ring fails its pointer-size asserts on arm64_32-apple-watchos. It also left two reqwest versions in the graph, since ed-acp and rmcp are already on 0.13. reqwest is now 0.13 everywhere: rustls on most targets, native-tls (Security.framework) on watchOS. embed::fetch_key needed no source changes; cargo check --features embed passes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
![sigit-code-review[bot]](https://avatars.githubusercontent.com/in/3492899?s=60&v=4){kind=small}
There was a problem hiding this comment.
This change updates the embed feature's optional reqwest dependency from version 0.12 to 0.13, switching from rustls-tls-native-roots to rustls on all platforms except watchOS, where it uses native-tls to avoid build issues with ring on arm64_32 watchOS. The Cargo.toml is modified to conditionally depend on reqwest 0.13 with appropriate TLS features per platform. No source code changes are needed as the used reqwest API remains compatible. This resolves a build failure on watchOS arm64_32 and removes duplicate reqwest versions in the dependency graph.
Automated review by siGit Code Review · commit 057e235 · see the review dashboard
paydii
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
embedfeature's optionalreqwestwas 0.12 withrustls-tls-native-roots, which pulls inring.ring0.17.14 fails its_ASSUMED_POINTER_SIZEasserts onarm64_32-apple-watchos, which blocks the SplitFire AI Watch app'sarm64_32slice (App Store Connect error 90733). It also put two reqwest versions in the graph, becauseed-acpandrmcpare already on 0.13.reqwest is now 0.13 with
jsonplusrustlson every target except watchOS, where it usesnative-tls(Security.framework).embed = ["dep:reqwest"]is unchanged.embed::fetch_keyonly usesClient::new,post,bearer_auth,header,timeout,send,statusandbytes, which are the same in 0.13, so there are no source changes.cargo check --features embedpasses, andCargo.lockhas a single reqwest.The watchOS build also needs the onde-ed change that does the same for
ed-acpanded-mcp(ondeinference/ed#41).