Skip to content

PREQ-8673: Increase legacy build-number migration buffer to 10000 #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hedinasr merged 1 commit into from
Sep 17, 2026
Merged

PREQ-8673: Increase legacy build-number migration buffer to 10000 #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion get-build-number/get_build_number.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ if [[ "$MAX_CLAIMED" -eq 0 ]]; then
fi
echo "Seeding from legacy build_number property: ${LEGACY_BUILD_NUMBER}"
# 10# forces base-10: a leading-zero property value would otherwise be parsed as an (invalid) octal literal.
MAX_CLAIMED=$((10#$LEGACY_BUILD_NUMBER + 1000)) # buffer against the legacy property still advancing elsewhere during migration
MAX_CLAIMED=$((10#$LEGACY_BUILD_NUMBER + 10000)) # buffer against the legacy property still advancing elsewhere during migration
fi
fi
fi
Expand Down
4 changes: 2 additions & 2 deletions spec/get_build_number_spec.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ Describe 'get_build_number.sh'
When run script get-build-number/get_build_number.sh
The status should be success
The output should include "Seeding from legacy build_number property: 42"
The output should include "Claimed build number 1043"
The contents of file "$BUILD_NUMBER_FILE" should equal "1043"
The output should include "Claimed build number 10043"
The contents of file "$BUILD_NUMBER_FILE" should equal "10043"
End

It 'should return an error if the legacy build number property is invalid'
Expand Down
Loading