PREQ-8673: Increase legacy build-number migration buffer to 10000 - #351
Conversation
v1 already published far more than 1000 numbers into Artifactory after the property snapshot. A 10000 gap keeps v2 from re-claiming those numbers during migration.
|
Code Review ✅ Approved🟡 Medium risk Increases the legacy build-number migration buffer from 1000 to 10000 to prevent v2 from re-issuing numbers already published to Artifactory when repos continue publishing with v1 after the initial snapshot. Shellspec test updated accordingly. No issues found. Review coverageFunctional validation 1 of 1 objectives covered Implementation Status ✅ 1 of 1 objectives covered✅ PREQ-8673 - 1 of 1 objectives coveredThis PR covers the objective to increase the legacy build-number migration buffer to 10000. ✅ 1 covered here
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |



PREQ-8673: Increase the v1→v2 migration seed buffer so new claims skip numbers already published to Artifactory.
Why
When no
refs/build-number/*exist yet, v2 seedsMAX_CLAIMEDfrom the legacy GitHubbuild_numberproperty plus a buffer. The buffer was 1000. Repos such assonarcloud-webappkept publishing with v1 after that snapshot, so v2 later re-issued numbers Artifactory already had.multiRepoPromotethen 500s (Multiple builds found for sonarcloud-webapp#N).Change
legacy + 10000instead oflegacy + 1000.42 + 1000 + 1 = 1043to10043.This only affects the first claim in a repo that still has no
refs/build-number/*. Repos that already have those refs are unchanged.Test plan
shellspec spec/get_build_number_spec.sh --shell bash— 18 examples, 0 failures