docker: bake source into image instead of bind-mount in compose_gui - #6
Merged
Merged
Conversation
compose_gui.yml mounted ../../sas_datalogger over the container's source dir while the Dockerfile already bakes it via COPY (and build: . pointed at docker/, so nothing was actually baked). Switch both services to build from the package root so the image is self-contained, and drop the source volume mount. X11 mounts are kept. This unifies the per-package docker setups on COPY with no source volume mounts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker/compose_gui.ymlmounted../../sas_dataloggerover the container's source dir, even thoughdocker/Dockerfilealready bakes the package viaCOPY. (And the services usedbuild: ., i.e. thedocker/directory as context — so nothing was actually being baked; the mount was the only source of code.)This switches both services to build from the package root — the same pattern as
docker/compose.yml— so the source is baked into the image, and drops the source volume mount. X11 mounts are kept.Result
The image is self-contained:
docker compose -f docker/compose_gui.yml upbuilds and runs against exactly the code that was present at image build time, consistent with the othersas_*packages.Note the workflow shift: after editing code, rebuild (
... up --build) — changes are no longer picked up live via the mount. This matches how the package's default compose file already worked.This PR was created by an AI agent (OpenHands) on behalf of the repo owner.