Skip to content

feat(compass): remove dead initial_prompt from the agent-session start path - #295

Merged
mattwilkinsonn merged 1 commit into
compass-server-fix-dispatch-errorresult-skewfrom
compass-server-sea-1959-initial-prompt-removal
Aug 13, 2026
Merged

feat(compass): remove dead initial_prompt from the agent-session start path#295
mattwilkinsonn merged 1 commit into
compass-server-fix-dispatch-errorresult-skewfrom
compass-server-sea-1959-initial-prompt-removal

Conversation

@seal-agent

@seal-agent seal-agent commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

This PR is part of a stack containing 2 PRs:

  1. main
  2. fix(runner): repair errorResult callsite skew breaking main build #294
  3. "feat(compass): remove dead initial_prompt from the agent-session start path" (this PR)

The initial_prompt field on StartAgentSessionRequest, SpawnAgentRequest, and the internal SpawnPeerRequest was accepted on the wire but never delivered to the agent — dead plumbing removed across the proto, all four generated trees, the go/server relay callers, and the compass-agent spawn tool; the freed field numbers and names are reserved for forward-compat hygiene. The go/e2e package is intentionally held (does not compile against the dropped field) pending a turn-driver ownership ruling.

Spec-impact: none

Refs SEA-1959

Co-authored-by: Matt Wilkinson matt@sealedsecurity.com

@linear-code

linear-code Bot commented Aug 12, 2026

Copy link
Copy Markdown

SEA-1959

@seal-agent
seal-agent force-pushed the compass-server-sea-1959-initial-prompt-removal branch from cbbf0be to 2fb5aa4 Compare August 12, 2026 22:06
…t path

The initial_prompt field on StartAgentSessionRequest, SpawnAgentRequest, and the internal SpawnPeerRequest was accepted on the wire but never delivered to the agent — dead plumbing removed across the proto, all four generated trees, the go/server relay callers, and the compass-agent spawn tool; the freed field numbers and names are reserved for forward-compat hygiene. The go/e2e package is intentionally held (does not compile against the dropped field) pending a turn-driver ownership ruling.

Spec-impact: none

Refs SEA-1959

Co-authored-by: Matt Wilkinson <matt@sealedsecurity.com>
@seal-agent
seal-agent force-pushed the compass-server-sea-1959-initial-prompt-removal branch from 2fb5aa4 to df73966 Compare August 12, 2026 22:11
@seal-agent

Copy link
Copy Markdown
Contributor Author

Review loop complete — review-clean, ready for merge gate. (head df739662)

The mandatory review agent ran two rounds:

  • Round 1 (head cbbf0be5): 1 medium + 1 low, both auto-fixed. Medium — go/e2e/legthreefour_test.go spawn tool-call JSON literal still hard-coded initial_prompt (build/runtime-harmless: a Go string literal, and arktype spawnParameters defaults to onUndeclaredKey:"ignore", so the key is silently dropped — which is why the -tags podman build passed — but it reintroduced the exact misleading surface this PR removes). Low — a stale StartSession(initial_prompt) doc comment in legtwo_test.go.
  • Round 2 (head 2fb5aa43): all-clear at the high+medium floor. Every lens PASS — proto reserved-hygiene (both field number and name reserved for all 3 messages), gen consistency (rawDesc bytes verified at byte level), go/server clean removal, TS lifecycle schema/mapping/test, wire-contract compatibility. One low (a drift-prone lifecycle.ts:79-93 line-span citation), also fixed → head df739662.

Every finding dispositioned (all fixed, none deferred). The strip is complete: zero live initial_prompt/initialPrompt/InitialPrompt references remain in non-generated source (only proto reserved entries + their generated rawDesc encoding).

Stack: #295 is stacked on #294 (base compass-server-fix-dispatch-errorresult-skew); jj-vine re-points the base to main automatically when #294 merges. Verified against #294's fixed tree: go build -tags podman ./... + untagged go build ./... exit 0, go vet -tags podman ./e2e/... exit 0, golangci 0, gofmt clean, full gated moon ci clean (32 tasks, 0 failed).

@mattwilkinsonn
mattwilkinsonn merged commit 3740d26 into main Aug 13, 2026
1 check passed
@mattwilkinsonn
mattwilkinsonn deleted the compass-server-sea-1959-initial-prompt-removal branch August 13, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants