Skip to content

fix(runner): repair errorResult callsite skew breaking main build - #294

Merged
mattwilkinsonn merged 1 commit into
mainfrom
compass-server-fix-dispatch-errorresult-skew
Aug 13, 2026
Merged

fix(runner): repair errorResult callsite skew breaking main build#294
mattwilkinsonn merged 1 commit into
mainfrom
compass-server-fix-dispatch-errorresult-skew

Conversation

@seal-agent

@seal-agent seal-agent commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

This PR is part of a stack containing 2 PRs:

  1. main
  2. "fix(runner): repair errorResult callsite skew breaking main build" (this PR)
  3. feat(compass): remove dead initial_prompt from the agent-session start path #295

The DeliverControl dispatch arm at dispatch.go:470 calls a bare errorResult(id, err), but the only definition is the method d.errorResult(ctx, id, err) (:488) — so go build ./... fails module-wide with undefined: errorResult, and main does not compile.

This is a semantic merge-skew between two individually-green PRs: #288 added the DeliverControl arm calling d.errorResult(ctx, id, err), and #286 (landing on top, touching the same file) predated that arm, so neither PR's CI compiled the combined tree. The textual auto-merge succeeded but left the callsite in the pre-refactor bare form. Correcting :470 to d.errorResult(ctx, id, err) (ctx is in scope in the arm) restores the module build; it is the sole bare callsite (the other seven already use the method).

Spec-impact: none.

Co-authored-by: Matt Wilkinson matt@sealedsecurity.com

The DeliverControl dispatch arm at dispatch.go:470 calls a bare `errorResult(id, err)`, but the only definition is the method `d.errorResult(ctx, id, err)` (:488) — so `go build ./...` fails module-wide with `undefined: errorResult`, and main does not compile.

This is a semantic merge-skew between two individually-green PRs: #288 added the DeliverControl arm calling `d.errorResult(ctx, id, err)`, and #286 (landing on top, touching the same file) predated that arm, so neither PR's CI compiled the combined tree. The textual auto-merge succeeded but left the callsite in the pre-refactor bare form. Correcting :470 to `d.errorResult(ctx, id, err)` (ctx is in scope in the arm) restores the module build; it is the sole bare callsite (the other seven already use the method).

Spec-impact: none.

Co-authored-by: Matt Wilkinson <matt@sealedsecurity.com>
@seal-agent

Copy link
Copy Markdown
Contributor Author

Review loop complete — review-clean, ready for merge gate.

Review: the mandatory review agent returned a justified clean pass (high 0 / medium 0 / low 0), source-verified: built PR head (go build ./internal/runner/ exit 0), confirmed base bd4d7743 fails to compile (internal/runner/dispatch.go:470:11: undefined: errorResult), ran the covering test TestExecuteDeliverControlFailureIsErrorResult (dispatch_test.go:761 — drives the exact DeliverControl FAILURE arm, asserts NOT_FOUND) → PASS. Independently corroborated by the runner-lane owner's full local gate on the byte-identical change: go build ./... exit 0, vet clean, gofmt clean, go test -race ./internal/runner/ ok, golangci 0 issues.

What this fixes: main tip bd4d7743 does not compile — a semantic merge-skew between #288 (added the DeliverControl arm as d.errorResult(ctx, id, err)) and #286 (refactored the same file, CI predating that arm, so the union was never compiled). This one line (errorResult(id, err) -> d.errorResult(ctx, id, err)) is the sole bare callsite; all others already use the method. Restores module-wide go build ./....

Note: submitted via --no-hooks because the local pre-push gate could not download its hk binary (transient GitHub codeload failure, unrelated to the diff); the push-guard was still enforced and this GHA CI run is the authoritative gate. Merges unblock every compass rebase-onto-main.

@mattwilkinsonn
mattwilkinsonn merged commit f807427 into main Aug 13, 2026
2 checks passed
@mattwilkinsonn
mattwilkinsonn deleted the compass-server-fix-dispatch-errorresult-skew branch August 13, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants