fix(runner): repair errorResult callsite skew breaking main build - #294
Conversation
The DeliverControl dispatch arm at dispatch.go:470 calls a bare `errorResult(id, err)`, but the only definition is the method `d.errorResult(ctx, id, err)` (:488) — so `go build ./...` fails module-wide with `undefined: errorResult`, and main does not compile. This is a semantic merge-skew between two individually-green PRs: #288 added the DeliverControl arm calling `d.errorResult(ctx, id, err)`, and #286 (landing on top, touching the same file) predated that arm, so neither PR's CI compiled the combined tree. The textual auto-merge succeeded but left the callsite in the pre-refactor bare form. Correcting :470 to `d.errorResult(ctx, id, err)` (ctx is in scope in the arm) restores the module build; it is the sole bare callsite (the other seven already use the method). Spec-impact: none. Co-authored-by: Matt Wilkinson <matt@sealedsecurity.com>
|
Review loop complete — review-clean, ready for merge gate. Review: the mandatory What this fixes: main tip Note: submitted via |
This PR is part of a stack containing 2 PRs:
mainThe DeliverControl dispatch arm at dispatch.go:470 calls a bare
errorResult(id, err), but the only definition is the methodd.errorResult(ctx, id, err)(:488) — sogo build ./...fails module-wide withundefined: errorResult, and main does not compile.This is a semantic merge-skew between two individually-green PRs: #288 added the DeliverControl arm calling
d.errorResult(ctx, id, err), and #286 (landing on top, touching the same file) predated that arm, so neither PR's CI compiled the combined tree. The textual auto-merge succeeded but left the callsite in the pre-refactor bare form. Correcting :470 tod.errorResult(ctx, id, err)(ctx is in scope in the arm) restores the module build; it is the sole bare callsite (the other seven already use the method).Spec-impact: none.
Co-authored-by: Matt Wilkinson matt@sealedsecurity.com