Repository navigation
test(host): stop shadowing the withheld variables test's reader - #230
Merged
Merged
Conversation
gcc 14 refuses the test from #227 under -Wshadow -Werror: the lambda kRead names its output path kRead too, which clang accepts. Main's gcc-debug tree no longer built, so its check failed.
siracozmen01
commented
Nov 8, 2026
siracozmen01
left a comment
siracozmen01
left a comment
Contributor
Author
There was a problem hiding this comment.
Review at dd0348f: ready, once CI goes green.
- The rename is the whole change. The diff touches only
modules/process/tests/child_test.cpp. Inside the lambda, the path's declaration and both of its uses (.outputandtest::readFile) becomekOutput. No otherkReadstood for the path, so every reference resolves to the same object as before. - The test tests the same thing. The child still runs
variable <name>with the samewithheldlist and writes to the same scratch file. The two expectations ("none" for the withheld variable, "given" for the other) are unchanged. - The body has Problem, Change and Verification, and no column-0
name(line.
No findings.
siracozmen01
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Main's check on dff8e53 failed because the gcc-debug tree does not build. In
AChildIsNotGivenTheVariablesWithheldFromIt, added by #227, the lambdakReaddeclares its output path askReadtoo. gcc 14 refuses that under-Wshadow -Werror("declaration of 'kRead' shadows a previous local"); clang accepts it, and a pull request's check builds only clang trees.Change
kOutput. Nothing else changes.Verification
rawframe_process_testsbuilds and passes 5 of 5. With main'schild_test.cppput back, the same build fails with the error above.tools/check.sh changedpassed before the push.Closes #229