Skip to content

chore(family): sync .github v0.0.56 - #420

Merged
siracozmen01 merged 1 commit into
mainfrom
chore/sync-family-0.0.56
Nov 5, 2026
Merged

siracozmen01 merged 1 commit into
mainfrom
chore/sync-family-0.0.56

Conversation

@siracozmen01

Copy link
Copy Markdown
Collaborator

Problem

maul3d's family files match .github v0.0.54, but family_sync.py --check maul3d against v0.0.56 reports 2 differences (#419). The release gate requires the shared files to match their canonical copies, so release 1.1.0 waits on this sync.

Change

  • family_sync.py --write maul3d from v0.0.56 writes the two files that v0.0.55 (b0d09a4) changed:
    • tools/fuzz_target.sh: a finding's report also keeps up to five of the harness's own FILE:LINE: expectation failed: ... lines, read from the log above libFuzzer's first input dump like the rest of the report.
    • docs/internals/maul-conventions.md: a harness's failure message names the broken promise and the values that broke it, never the input's bytes, as one such line.
  • v0.0.56 itself changes only the shared cpp.yml workflow. The workflow pins stay at v0.0.51 (972ea41).
  • maul3d's harnesses stop with abort and print no such line yet. Making them print one is a separate test change, after 1.1.0.

Verification

  • family_sync.py --check maul3d against v0.0.56 reports 0 differences on this head.
  • shellcheck tools/fuzz_target.sh passes.
  • A probe target that prints fuzz_probe.c:8: expectation failed: ... and aborts on an input starting with Q, run through the synced script for 20 s: it exits 1, and the report holds the crash count, that line and the sanitizer's deadly-signal report, with no input bytes.
  • tools/check_docs.py, the organization's docs_check.py and tools/check_source.py pass. tools/check.sh pr was not run: it neither builds nor runs either file, and CI runs the synced script in its fuzz jobs.

Closes #419

@siracozmen01 siracozmen01 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review at 1a0869a: no change needed. I read it; I did not run it.

  • The two hunks are the v0.0.55 change I reviewed in .github #128: the new grep -E -m 5 '^[^ ]+:[0-9]+: expectation failed: ' line in tools/fuzz_target.sh, its header comment, and the sentence in maul-conventions.md. The manager checked both files byte for byte against v0.0.56's maul/files copies.
  • The new grep reads $head, the log cut above libFuzzer's first input dump, as the existing lines do, so it adds no path for the input's bytes to reach the report. || true keeps a log with no such line from failing the report.
  • The body has Problem, Change and Verification, and has no column-0 word( or type(scope): line.

@siracozmen01
siracozmen01 merged commit 15ce6fa into main Nov 5, 2026
28 checks passed
@siracozmen01
siracozmen01 deleted the chore/sync-family-0.0.56 branch November 5, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

family files are behind .github v0.0.56

1 participant