Repository navigation
chore(family): sync .github v0.0.56 - #420
Merged
Merged
Conversation
siracozmen01
commented
Nov 5, 2026
siracozmen01
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review at 1a0869a: no change needed. I read it; I did not run it.
- The two hunks are the v0.0.55 change I reviewed in .github #128: the new
grep -E -m 5 '^[^ ]+:[0-9]+: expectation failed: 'line intools/fuzz_target.sh, its header comment, and the sentence inmaul-conventions.md. The manager checked both files byte for byte against v0.0.56'smaul/filescopies. - The new grep reads
$head, the log cut above libFuzzer's first input dump, as the existing lines do, so it adds no path for the input's bytes to reach the report.|| truekeeps a log with no such line from failing the report. - The body has Problem, Change and Verification, and has no column-0
word(ortype(scope):line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
maul3d's family files match
.githubv0.0.54, butfamily_sync.py --check maul3dagainst v0.0.56 reports 2 differences (#419). The release gate requires the shared files to match their canonical copies, so release 1.1.0 waits on this sync.Change
family_sync.py --write maul3dfrom v0.0.56 writes the two files that v0.0.55 (b0d09a4) changed:tools/fuzz_target.sh: a finding's report also keeps up to five of the harness's ownFILE:LINE: expectation failed: ...lines, read from the log above libFuzzer's first input dump like the rest of the report.docs/internals/maul-conventions.md: a harness's failure message names the broken promise and the values that broke it, never the input's bytes, as one such line.cpp.ymlworkflow. The workflow pins stay at v0.0.51 (972ea41).abortand print no such line yet. Making them print one is a separate test change, after 1.1.0.Verification
family_sync.py --check maul3dagainst v0.0.56 reports 0 differences on this head.shellcheck tools/fuzz_target.shpasses.fuzz_probe.c:8: expectation failed: ...and aborts on an input starting with Q, run through the synced script for 20 s: it exits 1, and the report holds the crash count, that line and the sanitizer's deadly-signal report, with no input bytes.tools/check_docs.py, the organization'sdocs_check.pyandtools/check_source.pypass.tools/check.sh prwas not run: it neither builds nor runs either file, and CI runs the synced script in its fuzz jobs.Closes #419