Skip to content

ci: take the family files and shared workflows at v0.0.51 - #311

Merged
siracozmen01 merged 1 commit into
mainfrom
family-v0.0.51
Nov 4, 2026
Merged

siracozmen01 merged 1 commit into
mainfrom
family-v0.0.51

Conversation

@siracozmen01

Copy link
Copy Markdown
Collaborator

Problem

maul2d carries the v0.0.47 family files, pins its workflows to v0.0.47, and builds clang-tidy's anchored header filter inline in tools/check.sh and ci.yml. .github v0.0.51 (972ea41) has a family tools/tidy_filter.sh that does the same, a third NOLINTNEXTLINE in src/cpu.h, and two conventions rules (#310).

Change

  • family_sync.py --write at v0.0.51: tools/tidy_filter.sh (new, executable), src/cpu.h (its comment and a NOLINTNEXTLINE(readability-redundant-declaration) on the third declaration, fix(maul): mark cpu.h's CheckCpu, which a public header may repeat .github#118) and docs/internals/maul-conventions.md (the tidy row names tools/tidy_filter.sh, plus docs(maul): say how state a caller holds is checked .github#119 and One cast hit type for closest and all-hit casts #120).
  • tools/check.sh and both clang-tidy steps of ci.yml: the filter comes from filter=$(tools/tidy_filter.sh <build tree>) on its own line, so a failure there stops the step instead of passing an empty filter. The inline CMAKE_HOME_DIRECTORY read and escape are gone.
  • .github/workflows/ci.yml, pr-gate.yml and pr-title.yml: the eight Rawframe-Project/.github references are pinned to 972ea41c6abf2652d3b067e57bf0713f1661cf0e # v0.0.51. Between v0.0.47 and v0.0.51 no file under .github/workflows/ or .github/actions/ of .github changed, so no shared workflow behaves differently.

AGENTS.md's list of shared family files does not gain tools/tidy_filter.sh here; no check reads that list.

Verification

  • family_sync.py --check reports 0 differences, and the synced tools/tidy_filter.sh equals the one at v0.0.51.
  • A fresh clone of this branch, from its root, with return a == a; planted in a function in src/core.h and nothing else changed: tools/check.sh changed runs clang-tidy on all 68 sources and fails on misc-redundant-expression at src/core.h. Without the plant, it passes, and the linux-clang-20-asan preset runs 25 of 25 tests.
  • tools/check.sh parses with bash -n, every workflow file parses as YAML, and tools/check_source.py passes.

Closes #310

@siracozmen01 siracozmen01 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review at e922ae8. No changes needed. Read, not run. The checks were pending when I looked, so this approval assumes they pass.

  • The filter assignments are plain statements on their own lines:

    • ci.yml, filter=$(tools/tidy_filter.sh out/tidy) and filter=$(tools/tidy_filter.sh out/tidy-asserts), each right after its configure. The workflow's default shell is bash (ci.yml:29), which GitHub runs with -e.
    • tools/check.sh, tidy() declares local build filter, then assigns filter=$(tools/tidy_filter.sh "out/check-tidy-$build") as a plain statement, under set -euo pipefail (check.sh:33). tidy is called at check.sh:162 and at 186, not in a condition.

    header_filter and the inline root=/filter= builders are gone. Called with only a tree, the script prints the same ^<escaped home>/(src|include)/ with the same escape set.

  • Family files. tools/tidy_filter.sh is new with mode 100755, blob d61928e, and docs/internals/maul-conventions.md is 80f34b2. Both are the canonical blobs at 972ea41. The src/cpu.h comment and NOLINT are .github #118's. I did not compare that file by blob, since its guard name is per library; family_sync --check covers it.

  • Pins. All eight .github references move from v0.0.47 (19c1638) to the full 972ea41 sha: changes, docs-check, zizmor, cpp twice and cache-prune in ci.yml, plus pr-gate.yml and pr-title.yml.

  • AGENTS.md is left as it is, as agreed.

@siracozmen01
siracozmen01 merged commit c9a6e70 into main Nov 4, 2026
30 checks passed
@siracozmen01
siracozmen01 deleted the family-v0.0.51 branch November 4, 2026 04:42
@siracozmen01 siracozmen01 mentioned this pull request Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt .github v0.0.51 and its tidy_filter.sh

1 participant