Repository navigation
fix(maul): keep a harness's expectation lines in the fuzz report - #128
Merged
Merged
Conversation
siracozmen01
commented
Nov 5, 2026
siracozmen01
left a comment
Contributor
Author
There was a problem hiding this comment.
Review at 8d73817: ready. No findings. Read, not run.
- The cut still comes first.
head=$(sed -E '/^(MS: [0-9]|0x...,|artifact_prefix=|Base64: )/,$d' "$log")(line 103) deletes from the first line of any dump form to the end. The new grep, like the runtime-error grep and the ERROR-to-SUMMARYsedbeside it, reads only<<<"$head"(line 110), never$log. Nothing at or below a dump can reach the report, in a run or in a merge (whose dump has noMS:line, so it is cut at its byte,artifact_prefix=orBase64:line). -m 5bounds the lines. The pattern^[^ ]+:[0-9]+: expectation failed:is anchored and differs from the sanitizer form (FILE:LINE:COL: runtime error:), so neither grep takes the other's lines.- The merge path needs nothing. A harness's expectation aborts, and libFuzzer's SIGABRT handler prints
==PID== ERROR: libFuzzer: deadly signaland writes a crash file. Either one already fails the merge check (lines 84-86: the new-file test and theERROR:grep). The merge then falls through to the same report, which now carries the expectation line too, from the same cut. - The docs line and the header comment state the form and its limit: the promise and the values, never the input's bytes. The script cannot enforce that, so it rests on each harness's message, which is what the convention line now says.
The body has Problem, Change and Verification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a fuzz harness breaks one of its own promises, CI's report cannot say which one.
tools/fuzz_target.shkeeps only the sanitizers'FILE:LINE:COL: runtime error:lines and theERROR:toSUMMARY:block, so a harness's own message is dropped. maul-audio's main went red on 2026-11-05 withfuzz_sceneaborting inExpectfromCheckRays, and the report showed only the stack: not which of its three checks failed or with what values, and the input stays on the runner by design.Change
fuzz_target.shalso keeps up to fiveFILE:LINE: expectation failed: ...lines from the part of the log above libFuzzer's first input dump, the same part it already reads.docs/internals/maul-conventions.mdname that form: a harness's failure message names the broken promise and the values that broke it, never the input's bytes.A library adopts it by having its harness's check print in that form; nothing else changes, and a harness that prints nothing reports as before.
Verification
bash -npasses.ERROR:/SUMMARY:block and then a mutation line, a byte dump andBase64:gives a report with the expectation line and the block, and none of the dump.