You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(cli): wait for the postInstall script before qwik add exits - #9371
qwik add <integration> returns from the integration's postInstall script before that script has finished. runInPkg returns { install, abort } synchronously, and runAddInteractive awaits the object instead of the install promise, so the spinner prints "Post install script complete" and the process hits process.exit(0) while the child is still running. The child is killed with it.
Three starters declare a postInstall today: playwright install, panda codegen --silent, and the Prisma starter's prisma contract emit (prisma migrate dev --name initial before #9358). None of them can finish unless they complete within a few milliseconds, and a failing script is never reported.
Change
Await the install promise, the same way check-client already does.
When the command exits non-zero: stop the spinner with Post install script failed: <script>, print an "Action Required" note with the command to rerun (npx <script> for npm, <pkgManager> <script> otherwise), and exit with status 1 instead of printing the Success footer. runCommand already logs the execa error above it.
How I tested it
Built the CLI from this branch (pnpm build.cli) and ran qwik add prisma --skipConfirmation=true against a fresh npm create qwik@rc -- empty app (Qwik 2.0.0-rc.4, Node 24.11.1, npm 11.6.2), with the Prisma starter from #9358 copied into dist/starters:
Before the fix: the CLI prints "Post install script complete" and exits, and prisma/contract.json is never written.
After the fix: the spinner runs for a couple of seconds, prisma/contract.json and prisma/contract.d.ts exist when the CLI exits, and npm run build passes.
With the starter's postInstall edited to prisma no-such-command: the CLI logs Command failed with exit code 2: npx prisma no-such-command, stops the spinner with "Post install script failed: prisma no-such-command", prints the Action Required note with npx prisma no-such-command, does not print the Success footer, and exits with status 1.
pnpm vitest run packages/qwik/src/cli: 152 tests pass.
#9358 depends on this: its postInstall generates the files the starter's prisma/db.ts imports.
No actionable comments were generated in the recent review.
Walkthrough
The interactive qwik add flow now checks the post-install result. On success, it reports completion. On failure, it displays a rerun command and exits with status 1. A patch changeset describes this behavior.
Changes: Post-install reporting
Layer / File(s)
Summary
Post-install result handling packages/qwik/src/cli/add/run-add-interactive.ts, .changeset/fix-cli-await-post-install.md
The flow reports completion when the post-install command succeeds. On failure, it displays a red failure message and a rerun command, then exits with status 1. The changeset describes this behavior.
QwikDev/qwik#9358: Adds a Prisma postInstall command that relies on qwik add waiting for post-install work to finish.
Suggested reviewers:shairez, manucorporat
Merge Risk: Minimal · up to a3279
The CLI now waits for post-install completion and correctly reports successful and failed commands.
Security architecture risk: Low · up to a3279
The CLI now waits for integration setup and reports failure accurately without changing how commands are selected or executed. Setup remains non-transactional: a failed script can leave partial changes, and safe recovery depends on that script.
Retained concerns
No architecture-level concerns identified.
Security review details
Security Blast Radius
inferred — The changed behavior affects the selected integration script’s opportunity to finish and the CLI’s reported outcome. No additional command source, execution target, or privilege mechanism is introduced by the compared change.
Trust Boundaries and Controls
observed — The existing integration lookup and confirmation flow remain ahead of commit and script execution. The changed branch does not bypass those steps or pass the CLI integration identifier directly as a command.
Resilience and Maintainability Implications
inferred — The non-transactional ordering predates this PR. Accurate failure reporting improves visibility, but the caller does not establish that a partly executed external script can safely be repeated or that interruption leaves recoverable state. These remain recovery uncertainties rather than verified introduced security findings.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "fix(cli): wait for the postInstall script before qwik add exits" matches the main change. The changeset and run-add-interactive.ts changes make runAddInteractive await the postInstall scrip…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "fix(cli): wait for the postInstall script before qwik add exits" matches the main change. The changeset and run-add-interactive.ts changes make runAddInteractive await the postInstall script's install promise, report success or failure, and exit with status 1 on failure. The title names the CLI, the postInstall wait, and the qwik add command, so it describes the primary fix. It is concise, specific, and follows a conventional commit prefix. It is 63 characters long, which is within a normal title length.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: f9bed805-dc08-4ed4-86f2-72530f94d56a
Commits
Reviewing files that changed from the base of the PR and between 6dd1965 and a3279bf.
Files selected for processing: 1
packages/qwik/src/cli/add/run-add-interactive.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
What is it?
Description
qwik add <integration>returns from the integration'spostInstallscript before that script has finished.runInPkgreturns{ install, abort }synchronously, andrunAddInteractiveawaits the object instead of theinstallpromise, so the spinner prints "Post install script complete" and the process hitsprocess.exit(0)while the child is still running. The child is killed with it.Three starters declare a
postInstalltoday:playwright install,panda codegen --silent, and the Prisma starter'sprisma contract emit(prisma migrate dev --name initialbefore #9358). None of them can finish unless they complete within a few milliseconds, and a failing script is never reported.Change
installpromise, the same waycheck-clientalready does.Post install script failed: <script>, print an "Action Required" note with the command to rerun (npx <script>for npm,<pkgManager> <script>otherwise), and exit with status 1 instead of printing the Success footer.runCommandalready logs the execa error above it.How I tested it
Built the CLI from this branch (
pnpm build.cli) and ranqwik add prisma --skipConfirmation=trueagainst a freshnpm create qwik@rc -- emptyapp (Qwik 2.0.0-rc.4, Node 24.11.1, npm 11.6.2), with the Prisma starter from #9358 copied intodist/starters:prisma/contract.jsonis never written.prisma/contract.jsonandprisma/contract.d.tsexist when the CLI exits, andnpm run buildpasses.postInstalledited toprisma no-such-command: the CLI logsCommand failed with exit code 2: npx prisma no-such-command, stops the spinner with "Post install script failed: prisma no-such-command", prints the Action Required note withnpx prisma no-such-command, does not print the Success footer, and exits with status 1.pnpm vitest run packages/qwik/src/cli: 152 tests pass.#9358 depends on this: its
postInstallgenerates the files the starter'sprisma/db.tsimports.Checklist
pnpm change