Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 75 additions & 6 deletions .github/workflows/agent-scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ on:
- created

jobs:
agentscan:
agentscan-pr:
runs-on: ubuntu-latest
if: github.event_name == 'pull_request_target'
permissions:
pull-requests: write
issues: write
contents: read
steps:
# - name: Cache AgentScan analysis
Expand All @@ -32,15 +32,84 @@ jobs:
- name: AgentScan
uses: MatteoGabriele/agentscan-action@8112fb79b33fafb8506159df20129a34209ac410 # v2.5.0
with:
# allowed-users: "angatha,ennamarie19,niccokunzmann,peskypotato,SashankBhamidi,stevepiercy"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore this comment and uncomment it. While we're on the collective, we must list only the users whom we trust.

The collective GitHub organization has too many Owners and Collaborators that are not trusted. See https://github.com/collective/icalendar/pull/1962/changes#r4291548063

Also repeat this pattern for issues.

honeypot: true
message-honeypot: "Thanks for the {type}, @{username}! A maintainer will review it shortly."
message-honeypot-first-time: "Welcome, @{username}! Thanks for your first {type} here!"
message-honeypot: |
Thanks for opening the pull request, @{username}!

A maintainer will review it within the next 3 days.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a big promise that we shouldn't make. If you alone can keep that promise, then it's fine, but there's no way that I'm going to commit to any set time frame.

Suggested change
A maintainer will review it within the next 3 days.
A maintainer will review it shortly.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm.

I was curious about what really happens..

Last 2 months response time to issues and PRs

The graph below is already exponentially corrected for the time spans.

image

The exponential distribution is a better fit than the normal distribution which people commonly use because the std error is lower.

class                     n  fit            average  std error     median      95%
collaborator or higher  160  exponential  23h 18min   1h 51min   16h 9min   2d 21h

We can see that with 95% probability, a first response from someone with higher rights to the repo happens within 2d 21h.

image

Issues usually get a response within 2d 6h and with 95% certainty within 9d 17h.

$ gh-community response collective/icalendar  --since 2026-08-20

Since icalendar started on GitHub

image

If we take icalendar over the whole of its existance: ~5 days average, ~2 weeks 95% for PRs

image

For issues though: average half a year and 95% is 2 years.

Good news: It got better!!!!!

$ gh-community response collective/icalendar

Summary

Based on data, I can give collaborators clarity on what to expect. I would not want to give a promise but we can share the idea.

Which data would you need to be ok with merging a statistics based assumption.


Please, make sure you use our [Pull Request Template](https://github.com/collective/icalendar/blob/main/.github/pull_request_template.md) and check as many boxes as you can.
If there is another Pull Request open for the same issue, review it and help make it better with your ideas.

Our [contributing guide](https://icalendar.readthedocs.io/en/stable/contribute/index.html) should answer most of your questions.
If you still have any questions, please leave a comment!

While you are waiting: we appreciate your review on other open Pull Requests.
That helps us maintainers speed up merges.

Thank you for your contributions! 🙏
Comment on lines +41 to +50

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this is too much. Instructions for using the pull request template belong in the authoritative source, the pull request template itself. Same for anything that the author should do.

Suggested change
Please, make sure you use our [Pull Request Template](https://github.com/collective/icalendar/blob/main/.github/pull_request_template.md) and check as many boxes as you can.
If there is another Pull Request open for the same issue, review it and help make it better with your ideas.
Our [contributing guide](https://icalendar.readthedocs.io/en/stable/contribute/index.html) should answer most of your questions.
If you still have any questions, please leave a comment!
While you are waiting: we appreciate your review on other open Pull Requests.
That helps us maintainers speed up merges.
Thank you for your contributions! 🙏

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People omit the PR template: #1959

People who used it should be alright. That can be a follow-up issue so it only appears when the PR template has not been used.

Also, the pull request template helps to create the PR.

I want people to review. We need reviewers.
People should also check PRs that are related. That can be moved.

You may also link to open pull requests that address the same issue, if applicable.

- See #PULL_REQUEST_NUMBER

That should then be improved.


There is a difference between

  1. Me submitting a PR template, possibly forgetting that and then stuff being commented out, not clickable. How can you be greeting people in a PR template?
  2. Me getting a response to my submission, an email and a hey, we see you, this is what is gonna happen next.
    I will take a break and have a look at the other suggestions.

message-honeypot-first-time: |
Welcome, @{username}! Thanks for your first Pull Request here! 🥳
A maintainer will give you a review within the next 3 days.

Please, make sure you use our [Pull Request Template](https://github.com/collective/icalendar/blob/main/.github/pull_request_template.md) and check as many boxes as you can.
If there is another Pull Request open for the same issue, review it and help make it better with your ideas.

Because this is your first contribution, we will take special care to help you get started.
Please, refrain from opening another Pull Request until this one is done.

Also familiarize yourself with our [contributing guide](https://icalendar.readthedocs.io/en/stable/contribute/index.html).
And while you are waiting, you can have a look around - there are other open Pull Requests from contributors like you.
You are invited to review their work and in that spirit receive a review yourself.

If you have any questions, please feel free to reach out and leave a comment.
Thank you very much! 🙏
label-automation: "agentscan:automated-account"
label-community-flagged: "agentscan:community-flagged"
label-mixed: "agentscan:needs-review"
mode: full
scan-issues: true
scan-pull-requests: true
trusted-author-associations: "owner,collaborator" # for collective, we allow those registered on the project only to not receive a scan message

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment you wrote is not what the permission does. There's over 1000 collaborators in the Collective. You can check with the GitHub REST API.

Suggested change
trusted-author-associations: "owner,collaborator" # for collective, we allow those registered on the project only to not receive a scan message
# trusted-author-associations: "owner,collaborator" # for collective, we allow those registered on the project only to not receive a scan message


agentscan-issue:
runs-on: ubuntu-latest
if: github.event_name == 'issues'
permissions:
issues: write
contents: read
steps:
- name: AgentScan
uses: MatteoGabriele/agentscan-action@8112fb79b33fafb8506159df20129a34209ac410 # v2.5.0
with:
honeypot: true
message-honeypot: |
Thanks for opening this issue, @{username}!

Please have a look of you find any other related issues and leave them a comment about this one.
Our [contributing guide](https://icalendar.readthedocs.io/en/stable/contribute/index.html)
should tell you what to expect. It is always worth a read.

---

A general note:
We do not assign issues, if you would like to work on this issue, please go ahead and open a Pull Request.
message-honeypot-first-time: |
Welcome, @{username}! Thanks for opening your first issue here!

Please have a look of you find any other related issues and leave them a comment about this one.
Also, check our [contributing guide](https://icalendar.readthedocs.io/en/stable/contribute/index.html).
If you have any questions, feel free to ask!

---

A general note:
We do not assign issues, if you would like to work on this issue, please go ahead and open a Pull Request.
label-automation: "agentscan:automated-account"
label-community-flagged: "agentscan:community-flagged"
label-mixed: "agentscan:needs-review"
mode: full
scan-issues: true
scan-pull-requests: true
# trusted-author-associations: "owner"
trusted-author-associations: "owner,collaborator" # for collective, we allow those registered on the project only to not receive a scan message

1 change: 1 addition & 0 deletions news/1818.internal
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update greeting messages for issues and pull requests. @niccokunzmann
Loading