Repository navigation
Change welcome messages - #1962
niccokunzmann wants to merge 4 commits into
Conversation
|
Thanks for the pull request, @niccokunzmann! A maintainer will review it shortly. |
stevepiercy
left a comment
There was a problem hiding this comment.
This is way too much and duplicates existing instructions where they are most effective. You've also got permissions wrong. I'd just close this.
| mode: full | ||
| scan-issues: true | ||
| scan-pull-requests: true | ||
| trusted-author-associations: "owner,collaborator" # for collective, we allow those registered on the project only to not receive a scan message |
There was a problem hiding this comment.
The comment you wrote is not what the permission does. There's over 1000 collaborators in the Collective. You can check with the GitHub REST API.
| trusted-author-associations: "owner,collaborator" # for collective, we allow those registered on the project only to not receive a scan message | |
| # trusted-author-associations: "owner,collaborator" # for collective, we allow those registered on the project only to not receive a scan message |
| - name: AgentScan | ||
| uses: MatteoGabriele/agentscan-action@8112fb79b33fafb8506159df20129a34209ac410 # v2.5.0 | ||
| with: | ||
| # allowed-users: "angatha,ennamarie19,niccokunzmann,peskypotato,SashankBhamidi,stevepiercy" |
There was a problem hiding this comment.
Restore this comment and uncomment it. While we're on the collective, we must list only the users whom we trust.
The collective GitHub organization has too many Owners and Collaborators that are not trusted. See https://github.com/collective/icalendar/pull/1962/changes#r4291548063
Also repeat this pattern for issues.
| message-honeypot: | | ||
| Thanks for opening the pull request, @{username}! | ||
|
|
||
| A maintainer will review it within the next 3 days. |
There was a problem hiding this comment.
That's a big promise that we shouldn't make. If you alone can keep that promise, then it's fine, but there's no way that I'm going to commit to any set time frame.
| A maintainer will review it within the next 3 days. | |
| A maintainer will review it shortly. |
There was a problem hiding this comment.
Hm.
I was curious about what really happens..
Last 2 months response time to issues and PRs
The graph below is already exponentially corrected for the time spans.
The exponential distribution is a better fit than the normal distribution which people commonly use because the std error is lower.
class n fit average std error median 95%
collaborator or higher 160 exponential 23h 18min 1h 51min 16h 9min 2d 21h
We can see that with 95% probability, a first response from someone with higher rights to the repo happens within 2d 21h.
Issues usually get a response within 2d 6h and with 95% certainty within 9d 17h.
$ gh-community response collective/icalendar --since 2026-08-20Since icalendar started on GitHub
If we take icalendar over the whole of its existance: ~5 days average, ~2 weeks 95% for PRs
For issues though: average half a year and 95% is 2 years.
Good news: It got better!!!!!
$ gh-community response collective/icalendar
Summary
Based on data, I can give collaborators clarity on what to expect. I would not want to give a promise but we can share the idea.
Which data would you need to be ok with merging a statistics based assumption.
| Please, make sure you use our [Pull Request Template](https://github.com/collective/icalendar/blob/main/.github/pull_request_template.md) and check as many boxes as you can. | ||
| If there is another Pull Request open for the same issue, review it and help make it better with your ideas. | ||
|
|
||
| Our [contributing guide](https://icalendar.readthedocs.io/en/stable/contribute/index.html) should answer most of your questions. | ||
| If you still have any questions, please leave a comment! | ||
|
|
||
| While you are waiting: we appreciate your review on other open Pull Requests. | ||
| That helps us maintainers speed up merges. | ||
|
|
||
| Thank you for your contributions! 🙏 |
There was a problem hiding this comment.
All of this is too much. Instructions for using the pull request template belong in the authoritative source, the pull request template itself. Same for anything that the author should do.
| Please, make sure you use our [Pull Request Template](https://github.com/collective/icalendar/blob/main/.github/pull_request_template.md) and check as many boxes as you can. | |
| If there is another Pull Request open for the same issue, review it and help make it better with your ideas. | |
| Our [contributing guide](https://icalendar.readthedocs.io/en/stable/contribute/index.html) should answer most of your questions. | |
| If you still have any questions, please leave a comment! | |
| While you are waiting: we appreciate your review on other open Pull Requests. | |
| That helps us maintainers speed up merges. | |
| Thank you for your contributions! 🙏 |
There was a problem hiding this comment.
People omit the PR template: #1959
People who used it should be alright. That can be a follow-up issue so it only appears when the PR template has not been used.
Also, the pull request template helps to create the PR.
I want people to review. We need reviewers.
People should also check PRs that are related. That can be moved.
You may also link to open pull requests that address the same issue, if applicable.
- See #PULL_REQUEST_NUMBER
That should then be improved.
There is a difference between
- Me submitting a PR template, possibly forgetting that and then stuff being commented out, not clickable. How can you be greeting people in a PR template?
- Me getting a response to my submission, an email and a hey, we see you, this is what is gonna happen next.
I will take a break and have a look at the other suggestions.
|
People omit the PR template, also, I go confused: The quality check is still working. |
Linked issue
Description
When we get a PR or an issue, it is important to guide contributors.
Both new and old contributors have slightly different needs:
All of them want to know what the next steps are and when to expect a response from the team.
So, I have split up the jobs - one for issues, one for PRs to have longer custom messages.
They should also guide how to contribute in other ways useful for them and us in this situation (i.e. leave a review)
Checklist
Additional information