Repository navigation
Add type hints to vRecur class - #1959
fishingpoleroid wants to merge 7 commits into
Conversation
|
Thanks for the pull request, @fishingpoleroid! A maintainer will review it shortly. |
Insufficient dataNot enough activity yet to make a reliable assessment. This is an automated analysis by AgentScan |
|
This pull request did not pass quality checks and AI use is suspected. Please review Contribute and make any necessary amendments. |
niccokunzmann
left a comment
There was a problem hiding this comment.
This is nice and ready. Please add your github handle and disclose AI guidance if you prompted one.
Thanks!
| @@ -0,0 +1 @@ | |||
| Added type hints to vRecur class. No newline at end of file | |||
There was a problem hiding this comment.
Thank you, please add your github handle here.
There was a problem hiding this comment.
Oh it needs to be one line!
There was a problem hiding this comment.
Done. Sorry for the oversight.
|
Reviewed this locally on the PR branch.\n\nThe change. Type hints only — adds return type annotations to vRecur class. No runtime change.\n\nNothing to fix. Mergeable once CI is green. |
|
Another note: Please have a look at this. I think the until value is NEVER inside a list. That might be important for typing, so it is flagged up: #1987 |
|
@fishingpoleroid Could you address the review and please add resolve the merge conflicts? |
|
Conflicts resolved, and news file updated. |
niccokunzmann
left a comment
There was a problem hiding this comment.
Thanks for the changes. Here is another review.
|
|
||
| @classmethod | ||
| def parse_type(cls, key, values): | ||
| def parse_type(cls, key: str, values: str) -> list[Any]: |
There was a problem hiding this comment.
I think, this could be list[VPROPERTY] could you check?
There was a problem hiding this comment.
I believe .from_ical() method returns python primitives. List[Any] would be appropriate here.
29ebc3e to
03e5951
Compare
Fixes #1930
Added parameter and return type hints to
vRecurmethods (to_ical,parse_type,from_ical, andto_jcal).Tested changes locally with
pytest -k vRecur.