Skip to content

fix(agent): Send cloud Claude reasoning effort without plugins#2722

Open
charlesvien wants to merge 3 commits into
feat/codex-developer-instructionsfrom
fix/cloud-claude-reasoning-effort
Open

fix(agent): Send cloud Claude reasoning effort without plugins#2722
charlesvien wants to merge 3 commits into
feat/codex-developer-instructionsfrom
fix/cloud-claude-reasoning-effort

Conversation

@charlesvien

@charlesvien charlesvien commented Jun 17, 2026

Copy link
Copy Markdown
Member

Problem

Cloud Claude runs configured without plugins silently dropped the selected reasoning effort. effort was nested inside a claudeCode.plugins?.length gate, so plugin-less runs never sent it.

Changes

  1. Extract buildClaudeCodeSessionMeta so reasoning effort and plugins are independent
  2. Send Claude effort whenever it is set, not only when plugins are present
  3. Add tests for effort-only, codex, neither, and plugins+effort combinations

How did you test this?

Manually

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit ad5cb12.

@greptile-apps

greptile-apps Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
packages/agent/src/server/agent-server.test.ts:1146-1176
**Missing combination test coverage**

The three tests cover the independent cases (effort only, codex-only, neither), but there is no test for the case where both `plugins` and `reasoningEffort` are provided with the `"claude"` adapter. That combination exercises the branch where both `options.plugins` and `options.effort` are populated together — a valid production path that is untested. A fourth case asserting `toEqual({ effort: "high", plugins: [...] })` would close the gap and also let the suite be collapsed into a parameterised table, which is the preferred style in this codebase.

Reviews (1): Last reviewed commit: "send claude effort to cloud runs without..." | Re-trigger Greptile

Comment thread packages/agent/src/server/agent-server.test.ts
@charlesvien charlesvien changed the title send claude effort to cloud runs without plugins fix(agent): Send cloud Claude reasoning effort without plugins Jun 17, 2026
@charlesvien charlesvien marked this pull request as ready for review June 17, 2026 05:45
@greptile-apps

greptile-apps Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Reviews (2): Last reviewed commit: "test claude effort and plugins combinati..." | Re-trigger Greptile

@charlesvien charlesvien force-pushed the fix/cloud-claude-reasoning-effort branch from 688d6b1 to ad5cb12 Compare June 17, 2026 06:19
@charlesvien charlesvien added the Stamphog This will request an autostamp by stamphog on small changes label Jun 17, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean bug fix — the old code accidentally gated reasoning effort behind a plugins guard, silently dropping it. The refactor is correct and all branches are covered by the new tests, including the combination case flagged by the bot reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stamphog This will request an autostamp by stamphog on small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants