fix(agent): Send cloud Claude reasoning effort without plugins#2722
Open
charlesvien wants to merge 3 commits into
Open
fix(agent): Send cloud Claude reasoning effort without plugins#2722charlesvien wants to merge 3 commits into
charlesvien wants to merge 3 commits into
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 17, 2026
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
packages/agent/src/server/agent-server.test.ts:1146-1176
**Missing combination test coverage**
The three tests cover the independent cases (effort only, codex-only, neither), but there is no test for the case where both `plugins` and `reasoningEffort` are provided with the `"claude"` adapter. That combination exercises the branch where both `options.plugins` and `options.effort` are populated together — a valid production path that is untested. A fourth case asserting `toEqual({ effort: "high", plugins: [...] })` would close the gap and also let the suite be collapsed into a parameterised table, which is the preferred style in this codebase.
Reviews (1): Last reviewed commit: "send claude effort to cloud runs without..." | Re-trigger Greptile |
Contributor
|
Reviews (2): Last reviewed commit: "test claude effort and plugins combinati..." | Re-trigger Greptile |
688d6b1 to
ad5cb12
Compare
joshsny
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
Cloud Claude runs configured without plugins silently dropped the selected reasoning effort.
effortwas nested inside aclaudeCode.plugins?.lengthgate, so plugin-less runs never sent it.Changes
buildClaudeCodeSessionMetaso reasoning effort and plugins are independenteffortwhenever it is set, not only when plugins are presentHow did you test this?
Manually
Automatic notifications