Skip to content

fix(agent): Preserve Codex base prompt via developer_instructions#2721

Open
charlesvien wants to merge 2 commits into
mainfrom
feat/codex-developer-instructions
Open

fix(agent): Preserve Codex base prompt via developer_instructions#2721
charlesvien wants to merge 2 commits into
mainfrom
feat/codex-developer-instructions

Conversation

@charlesvien

@charlesvien charlesvien commented Jun 17, 2026

Copy link
Copy Markdown
Member

Problem

Codex received PostHog's guidance through the instructions config key, which replaces Codex's model-optimized base prompt instead of appending to it.

Changes

  1. Pass guidance via Codex developer_instructions (appends) instead of instructions (replaces the base prompt)
  2. Rename the instructions option to developerInstructions across the agent and workspace-server call sites
  3. Add a spawn test asserting guidance uses developer_instructions, never the replacing key

How did you test this?

Manually

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Copy link
Copy Markdown
Member Author

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit ad7af09.

@greptile-apps

greptile-apps Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "append codex guidance via developer_inst..." | Re-trigger Greptile

@charlesvien charlesvien changed the title append codex guidance via developer_instructions fix(agent): Preserve Codex base prompt via developer_instructions Jun 17, 2026
@charlesvien charlesvien marked this pull request as ready for review June 17, 2026 05:45
@charlesvien charlesvien added the Stamphog This will request an autostamp by stamphog on small changes label Jun 17, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent internal rename of instructions to developerInstructions across the Codex adapter chain, with matching tests that verify the new subprocess config key and guard against the old ones. No external API contracts, security issues, or broken references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stamphog This will request an autostamp by stamphog on small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants