Skip to content

feat: add ICQ completion sound #2702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benben wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add ICQ completion sound #2702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added apps/mobile/assets/sounds/icq.mp3
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions apps/mobile/src/app/settings/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ const SOUND_OPTIONS: ReadonlyArray<{ value: CompletionSound; label: string }> =
{ value: "shoot", label: "Shoot" },
{ value: "slide", label: "Slide" },
{ value: "drop", label: "Drop" },
{ value: "icq", label: "ICQ" },
];

const VOLUME_OPTIONS = [
Expand Down
3 changes: 2 additions & 1 deletion apps/mobile/src/features/preferences/stores/preferencesStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ export type CompletionSound =
| "ring"
| "shoot"
| "slide"
| "drop";
| "drop"
| "icq";

export type InitialTaskMode = "plan" | "last_used";

Expand Down
3 changes: 3 additions & 0 deletions apps/mobile/src/features/tasks/utils/sounds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import {
// eslint-disable-next-line @typescript-eslint/no-require-imports
const dropAsset = require("../../../../assets/sounds/drop.mp3");
// eslint-disable-next-line @typescript-eslint/no-require-imports
const icqAsset = require("../../../../assets/sounds/icq.mp3");
// eslint-disable-next-line @typescript-eslint/no-require-imports
const knockAsset = require("../../../../assets/sounds/knock.mp3");
// eslint-disable-next-line @typescript-eslint/no-require-imports
const meepAsset = require("../../../../assets/sounds/meep.mp3");
Expand All @@ -27,6 +29,7 @@ const SOUND_ASSETS: Record<CompletionSound, number> = {
shoot: shootAsset,
slide: slideAsset,
drop: dropAsset,
icq: icqAsset,
};

let audioModeConfigured = false;
Expand Down
Binary file added packages/ui/src/assets/sounds/icq.mp3
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions packages/ui/src/features/settings/sections/GeneralSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,7 @@ export function GeneralSettings() {
<Select.Item value="slide">Slide</Select.Item>
<Select.Item value="switch">Switch</Select.Item>
<Select.Item value="wilhelm">Wilhelm scream</Select.Item>
<Select.Item value="icq">ICQ</Select.Item>
</Select.Content>
</Select.Root>
{completionSound !== "none" && (
Expand Down
3 changes: 2 additions & 1 deletion packages/ui/src/features/settings/settingsStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ export type CompletionSound =
| "shoot"
| "slide"
| "switch"
| "wilhelm";
| "wilhelm"
| "icq";

export type TerminalFont =
| "berkeley-mono"
Expand Down
2 changes: 2 additions & 0 deletions packages/ui/src/utils/sounds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import bubblesUrl from "../assets/sounds/bubbles.mp3";
import daniloUrl from "../assets/sounds/danilo.mp3";
import dropUrl from "../assets/sounds/drop.mp3";
import guitarUrl from "../assets/sounds/guitar.mp3";
import icqUrl from "../assets/sounds/icq.mp3";
import knockUrl from "../assets/sounds/knock.mp3";
import meepUrl from "../assets/sounds/meep.mp3";
import meepSmolUrl from "../assets/sounds/meep-smol.mp3";
Expand All @@ -27,6 +28,7 @@ const SOUND_URLS: Record<Exclude<CompletionSound, "none">, string> = {
slide: slideUrl,
switch: switchUrl,
wilhelm: wilhelmUrl,
icq: icqUrl,
};

let currentAudio: HTMLAudioElement | null = null;
Expand Down
Loading