feat: add ICQ completion sound#2702
Open
benben wants to merge 1 commit into
Open
Conversation
Adds the classic ICQ "Uh-oh!" new-message sound as a selectable completion sound on both desktop/web and mobile, following the existing sound pattern. Generated-By: PostHog Code Task-Id: 245d3f95-a569-4f32-967d-f9742e439044
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "feat: add ICQ completion sound" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
@ben.k wanted the nostalgic ICQ "Uh-oh!" new-message sound as a completion sound option instead of (well, alongside) meep. :blushing_cowboy:
Changes
Adds a new
icqcompletion sound, available on both desktop/web and mobile, following the existing sound pattern:icq.mp3(converted from the source WAV) inpackages/ui/src/assets/sounds/andapps/mobile/assets/sounds/.icqin theCompletionSoundtype, the sound URL/asset maps, and the settings selectors (labelled "ICQ") on both platforms.How did you test this?
Verified the changes follow the existing exhaustive
Record<CompletionSound, …>maps so the type system enforces the new key. Confirmed the converted MP3 is a valid ~0.45s audio file. (Did not run the full app —node_modulesisn't installed in this environment, so a project-wide typecheck couldn't run.)Automatic notifications
Created with PostHog Code from a Slack thread