README: crossing costs once the observation's bytes (E46), other trainers (E48, E49), the boundary is transparent (E50, E52, E53); E49's figure - #127
Merged
Conversation
…ners (E48, E49), the boundary is transparent (E50, E52, E53); E49's figure - README: the cost row now cites E46 (11.6 ms for 184 KiB at 23.7 MB/s, each observation once with reuse-feedback-obs) instead of E43's twice-the-bytes model; the E10 ratio is 12% on that link, not 21%. New rows for E49/E48 and E50/E52/E53. The experiment count no longer names a number that goes stale with every experiment. - experiments/README: plugrl-bridges is private, so its link 404'd; it is named as not public yet. The E10 row adds E46's 12%. - experiments/e49-multi-trainer/figure.py: every seed's curve from the bridge's episode logs, for the project page (docs/media/other-trainers.png in plugrl.github.io). Reruns are byte-identical.
It was written with CRLF, which pre-commit's mixed-line-ending hook rejects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README's table of answers had stood still since 09-29. Two of its rows were wrong by now, and three results were missing.
Corrected
reuse-feedback-obs, which the server offers and the env client uses by default. The old answer was E43's "twice the observation's bytes, 21 ms at 18 MB/s". E43 is still linked as the measurement before the feature.Added
plugrl-bridges, 3 of 3 seeds in every pairing.Also
experiments/README.mdlinked https://github.com/PlugRL/plugrl-bridges, which is private and 404s for everyone else. It now names the repository as not public yet. Its E10 row adds E46's 12%.experiments/e49-multi-trainer/figure.pydraws every seed's curve from the bridge's episode logs (results/registered/*/episodes.csv). It makes the figure on the project page (plugrl.github.io#25). The script passesruff checkandruff format, and two runs give byte-identical PNGs.