Improve buy similar matching and add abyss jewels - #10284
Merged
LocalIdentity merged 2 commits intoAug 26, 2026
Merged
Conversation
LocalIdentity
approved these changes
Aug 26, 2026
LocalIdentity
merged commit Aug 26, 2026
93708f5
into
PathOfBuildingCommunity:dev
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This PR improves the trade hash matching algorithm to cover more niche cases. I think this function is quite reliable now, and it only differs in some really weird trade site cases. The matching itself still suffers from PoB splitting mods in a different way, and e.g. magic flasks have some problems because of that.
This also adds the new timeless jewels to the pattern list. There are still an insanely low amount of these on the market, so I'm not sure if this is even useful.
Steps taken to verify a working solution: