Skip to content

Port "Improve buy similar matching" (#10284) - #2441

Merged
LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
vaisest:port-buy-similar-329
Aug 27, 2026
Merged

LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
vaisest:port-buy-similar-329

Conversation

@vaisest

@vaisest vaisest commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Ports PathOfBuildingCommunity/PathOfBuilding#10284. Timeless jewels still not included because it would be useless.

Steps taken to verify a working solution:

  • New tests converted to work with pob2 and old ones pass
  • Option-based options unchanged (PoB1 now has a different approach to this because the guy who fixed 3.29 options didn't copy the PoB2 implementation, but both seem to work the same)

vaisest and others added 2 commits August 27, 2026 19:28
Buy Similar now prefers the exact trade stat text when multiple
descriptors match. This selects the boolean Instant Recovery stat
without a numeric minimum, while percentage recovery mods still
keep their values.
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Aug 27, 2026
@LocalIdentity
LocalIdentity merged commit dc9f761 into PathOfBuildingCommunity:dev Aug 27, 2026
5 checks passed
@vaisest
vaisest deleted the port-buy-similar-329 branch August 28, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants