Skip to content

update mana efficiency mod on Militant Faith trade search #10219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trifall wants to merge 2 commits into from
Closed

update mana efficiency mod on Militant Faith trade search #10219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7891794
update mana efficiency mod on Militant Faith trade search
Trifall Aug 14, 2026
2aa40d5
formatting fix
Trifall Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Data/TimelessJewelData/LegionTradeIds.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ return {
[10] = "explicit.stat_3808469650",
[11] = "explicit.stat_2830135449",
[12] = "explicit.stat_2042813020",
[13] = "explicit.stat_3293275880",
[13] = "explicit.stat_1355915086",

@mcagnion mcagnion Aug 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Keep the finder item and Trade filter aligned

Codex traced this entry through the Trade query builder: selector id 14 is still labelled Skill Cost, and TimelessJewelListControl still generates 1% reduced Mana Cost of Skills per 10 Devotion, but this line maps that same selection to explicit.stat_1355915086 (#% increased Mana Cost Efficiency per 10 Devotion). The focused headless probe confirms that both modifier forms parse into real mods, id 14 produces the legacy item, and slot 13 contains the current id; TreeTab.lua:2289-2292 then copies that slot unchanged into the Trade filter.

PR #10276 now covers this same objective with separate legacy/current options, matching generated item variants, and the exact current Trade id. #10219 is therefore functionally superseded on this point rather than requiring a separate correction here.

[14] = "explicit.stat_2585926696",
[15] = "explicit.stat_2803981661"
}
Expand Down
Loading