Conversation
| [11] = "explicit.stat_2830135449", | ||
| [12] = "explicit.stat_2042813020", | ||
| [13] = "explicit.stat_3293275880", | ||
| [13] = "explicit.stat_1355915086", |
There was a problem hiding this comment.
[P1] Keep the finder item and Trade filter aligned
Codex traced this entry through the Trade query builder: selector id 14 is still labelled Skill Cost, and TimelessJewelListControl still generates 1% reduced Mana Cost of Skills per 10 Devotion, but this line maps that same selection to explicit.stat_1355915086 (#% increased Mana Cost Efficiency per 10 Devotion). The focused headless probe confirms that both modifier forms parse into real mods, id 14 produces the legacy item, and slot 13 contains the current id; TreeTab.lua:2289-2292 then copies that slot unchanged into the Trade filter.
PR #10276 now covers this same objective with separate legacy/current options, matching generated item variants, and the exact current Trade id. #10219 is therefore functionally superseded on this point rather than requiring a separate correction here.
|
Fixed in #10276 |
3 participants
Fixes #10191
Description of the problem being solved:
The Militant Faith 'Skill Cost' devotion modifier was generating trade searches for the legacy '#% reduced Mana Cost of Skills per 10 Devotion' modifier. Jewels dropped from 3.29 onward instead have '#% increased Mana Cost Efficiency per 10 Devotion'.
The trade modifier mapping now uses the current Mana Cost Efficiency trade stat. Legacy Militant Faith jewels remain supported in existing builds.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
N/A
Before screenshot:
After screenshot: