Skip to content

[0.5] Update Culling Strike Implementation#1952

Open
Peechey wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
Peechey:feature/update-cull
Open

[0.5] Update Culling Strike Implementation#1952
Peechey wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
Peechey:feature/update-cull

Conversation

@Peechey
Copy link
Copy Markdown
Contributor

@Peechey Peechey commented May 23, 2026

Fixes #93

Description of the problem being solved:

Reworking our cull implementation to use data.gameConstants instead of a hardcoded 10%. Updating NormalThreshold to 35% as of 0.5 patch notes. I'm also adding a breakdown. There are two other PRs for culling strike but both have slightly different solutions, neither use the game data, and neither had a breakdown, so I was looking for a more complete solution.

Also fixing a bug with Attrition where we were not checking the right actor for the threshold so we were always adding the cull, given the enemy is rareOrUnique. Now it required the 31 stacks as stated.

Steps taken to verify a working solution:

  • Culling Strike support
  • His Winnowing Flame
  • Culling Strike threshold tree nodes

Link to a build that showcases this PR:

eNrdG2tv4zby8-ZXCAYKtGgSS7L8SJDtwXGSjdtk49rJ5q5fCkZibF0oyZWoJG7R_34zJPWwE9uktyiK2wV2SWpenBkOh0P65F-vEbOeaZqFSfyx4RzaDYvGfhKE8fRj4-724qDX-NcPeycjwmc3j6d5yPCL-8PehxPRsThJp5R_KQjYvzoNi9FnyoBYu2H5M5ISn9P0Csf6OU-uk4B-bPA0pw0rImE8Sfwnyj-lST4HlIZFMp_GwYCRLPtMIgD9nMQA6lcDYxJPadqwnkP6IqkNr0c349sGSPXhZMTIgqYTTrj1TFgOX92Wd-i4Pbfr2m6r5zWsDD5-bPRh1mRKz0gE_zaaOyGf5mnGt1CwDzuA2nWPep7X81qtgsRkTmmwnq9dwI1Sev74SH0ePtNBGvLBjMQ-1UDUAa7DXueMh3MWgm7XwTt2Sf1yK3HHA3dquW2vfdR1nE6BeJtwws5Gk_UKW4ZMuD7kJrJu79C1QR7P7jktuzTDIGcMXFpLoDHNaPpMOLj6Rk7v-8wgiR7CmAb95-l61MN26WIpJTeP0vRjEoR5dk15SrO1uEfdAvWaxGSQZBqKQ8gRTWHJ8Y0I7d6h17Kd7pEHf3sr2BPqJ7BkTRkaYl6Fj1QfUmdSqwim0uw2j_OJLpwx4d0EGkP00oOcJDnbCNkrA8qEb4gi7W61on7bDFkAntHXtVDdoxq5jYAF3DDmmtJtgrQr4Z4TDAoagSoNH3K-Pma2W51Dz-102xg67N5SfDu_HK3Fax2VOhjNFlnoE3ZNXsMojyBO35Inul42t9OpnHo64zFEwx1wL8KU7oA2SFigi1abJGw9SabNrsK7hozjksRB3_dzSEwWGrYl6VNMs0x3d6DBVozaPDCMrHeGWqrgHyPoMPZ1qd7FqZJHF2MMMQPTmgdGdRKAZSYq9OgFzjGd0lixW-ihXFHqzz6B9YARGHy9gB23vtVoxDTULYJu0u0KVQ3d1hS1jLFNUZ0qA0BEQ1Uhiraq7JoSwtQE0kwBqzjavnIe03S6mMxCygIz6EJjAzLXdIE69iZXWMPOyEp1VF1rLW3Xevxa3YrjM8m0NiipCwm9SQ1eu0Y6oFuOAhX0NWWUmqGM0uS_ePxhhngwFcZ2QDHjV0sCHhmiJfEYTgjxVBtDl0E_jZI81TShBNZy5CJhkOfYMQ1yXy-ZKY-lpwwO8brTKLGEso1Q-5wT_-ksCabaVhFMjDCW5Zvk8znELVwOWwgctO16LgTZQKiTU1ewN7CYN8WrGgPMmnQZVLAGDMpMUJfLCsI2VvZSIqc9lQp4GwPnjTmvIVhGsO2Iust1sn5D8WqVl4yCybVO35VBc6ZX3hCAm2sW1RpNXmC-Myy2bcgr34OGJFlDlJTGvy-06S-BazE4jwPIt0GX2jxWMSo2p_njY2ZB_p7RK_CEj42G9QBDRdtPogfCVU9i3IYRbDtZdkY4sQJ1WPtC0pDE3BG-sjLoSgcSpcmLkHGangE9lEbOiZLUnyGLC8LYA8QkZFyNKsYnTVEjxdaQ0yizslnygpM9C8EpU3StrCiF5hmVZ_Z7SuZJPKFA5JGwDD4R4b5IQYw6ss6JfSsMhKDPUmqs5-G3D2Po88Wxdfd5-PPd-d5lMp3lMd-7gHhGA-tTSgn3Wf6wp2Z7bIGnW_ahc-hUQ4M8BQn53oTiHgVo5Rd37-ecMMHAtfdEYRcOyseWvTeM5iz0Q55h5w8l1bHz5x8plmyP7cP2n99CXnjgtO3vvrHC2AdJMiBd7ECW3IIqVLeO2g-CzPrW6Ry49ncWT6xv3daB2_3uDfb3Tvsb_I41TTEOaZUlg_eeY39jpbjDAVe5m1giHgCSjTgTWOPxlM_24KAYWUm8RARVewKRQxSgC90L-bDK25bOtgLhboVobYXwtkK030KcNNFDll3lffe4XqRhZt29JuneABNKbl0mSbCnksBjq-V111i83Vkxec3Onn3QWbayImjJ9KgO_H3pFWiD4mz-LqAki2CRPP1beOQBu9p1Vqqoi-YMn6h1O4PIPYN98B9kwRX7wNIu5FkfCiTlCUsAFnBGD3fjK4w8sbgXuWAke7JAXPw2DDBSNTdjYGiNrJYBhuThGGBc0akRPCSuRvByDkYcopxR_h6CiPfDAKDfw_uRvlBmeZ0eVjnjJKCILLtbOEpDGpnmE4OlmBkgjNHfHVOElqElXUNLmnujazoFEwRlCMeavEDuqI93Shk3Z-Mas0kSnhnBBwtLHQv1sS4pi-r-r-u-Nedy6jEMApTMslI4LU9EEnRP8TiQySRI5D7YGhDmZzLixfOcK-pRmPm_YgKHd7mY_aXi7vn84uJ8cDv8cq5Y1VGyp5CxX-M8esB7YPl_JdREnsKtLH_IZPNj40tIXyaIdUY5CRkqGaYhRmSCg3kjY2QOu0cRbddTE3iQEKibX0Gr1jWgdP4K-y3M9x60loZUyVX1TIWSIuAujjmvpIY3qCaEZF40IBmHDVjRkJfVJlQwcVLTwaYRLiQVhCnORdtUE3wxp9mc-uFj6GPOXTf5LXxTYyZ6Ke4MCnurgoAJjVMm9IgEVNMAeZSEWRJL7KJtotVpHBb2LNoG6GfUJ2ruqmmAXFY5kxiLnIJKOWZE6XMSCyeHRdMPGR7olWXPGa0GDAje8BlNZZVAUbqGiFQOmC0ceb2n6NT7JrrCOyGpIdEyQBVXHnIOomWyaOQVgFrtoemSXSrVS3ssjRiQkgUepUNVGjIyQ7EhBlXbZCaqVC4nUXRMFoqIwf3nJAxkfBBLZnXQKGhAYvr1ZEQV9C8gU9a5v56WOE4oSxdtA_Q7HuKpdAsVUWDZvNy-jgKuta-jIFLfnbHHZRIyXs0_NPhOi3BVdvTxyyLdzhRkKXFndFHp3BlbhH7wZ1GJq2J_NWISP3ken4EyqoWxMykh1kr8WEtMZ4pqX9Sc6RaKcr3LFxe1AKAGTOMkbOOXZaK4K6Wyxn9JCeOzUZKwryO4-rLkq4jhPW0-J3FQkLtZTs_XkN1mBjgqAk1RYT7D6-Cv1WFMo4UOoVKuk2ZxoDv5nECSg6RxtOicDJL4MZyq-rXs1CvY5UhR-OIhZ1RsMCSH87Y8lNbPfVgUC1FcIeyYpPQmvYvD37CA_gBGpySu620ZmSJO9cZVkChueGS9LavOki3vPRJ-nvEkgnNqVp1TfVVqzESp8eBgLethdppkNUTRU8AjRnyKBUqaKpTJDPb8CR7Esjcn3PfgBYvatWA1E3s9UlRqA6NXTPHZBMQJttBnuXpRqMV3MMNzt_7kKjmLmxP-Cf4hAcXb00Bf2uWr7pqwvW3TxJp3jU97C7y6S4dVI4rAFWZ3g1oCGiXxRZJGb1RjbzN89dS7RNomorhMXVXEpoll4TRkN49iywUJxV6r7ZlpVR7R8RCpRHXnVqG4OopAA99TIt7grWpyK4HSn41dBF3RBKlyanXVtnxgqmy_QeQyIA6SNM3nWEkapIs3xtEKAaLotLjLDKPAO2uzH0WJ4cIszmml83pbEFRBqlpWtkZsNDHPxE9Sf7ZTkLoPMemigUAeJHnMJ5Q9GkSP8tRZYmx3_No7ihLN1nDZdXEbdvdif5Z7vehh8zalFOup1u9JEl2p3_rA9o3df39sHHRbrcOu4xw5Xcc9wsfU-OE_8MFxeu6h0-u2W7bttvCCff19uLxMn_BU7rAy4RhG8yTlFn3F_0Yk5Yt6XiMEU9kGvoEqEw3sqN8VQThZDGNO05gwLGRD0oGzqX6-hI8_RDJA0kW_-ikSwsYhU79DkmV21a5RU_dCGcYZr9Pdd-wj-2i_bXvto33XO3Ldffz5BIz3jtzWvtPxekf7Xq_d6e2La6R9p9u1XTHuwbhnO_tOq-f29tu9lgPjjmfvO-223d1veS58dDvdXmffc118txORDARZqLoVzowsi2-rhOpufCUaH2acz7PjZvPl5eVwTvgseaSvIaOHfhI154AEajwQlfYD1FGzD39Op_3--dOvv_80d2b32cUv4Bx98uB6fPHjxY9Pp0_P43P39GY0PL38uffk3f9CfvqJDQBHMG4WnNVFW6acE9PhNAxkAgn9smxWfLAC-vpZ6hVS05iXbUilVFtpTuhbqkgqRyqqrm-hRalcZRJhAKV0oUslV3NJsJMmupFYCuhn2BC15MzKwBk_0Sg7XZyNJhcYvavf-uDjHhBfJLQAo67R5SOSOlrh9hWoWlgxpAPlW_7iLYi6t-DylQouonw-l-SwtA366F9dKd9XoCrHVvrHQfHru35FTxBj5AG5NlY_ikxfQEDa9cDKcwDeubM8oMNYPXtauqr-cAISifc8IMEwBjOqVSSJfGLJA2FOueRrcIqfXHIYQQXvqbx9uqacBIQTebPURCU2hZRCbWQ-YSQqH8UMRaW5GPytZoC6EG4hhPrtomu_malYCnVq8vGSvCST8Qa_WIJR8--df7NyAPX0Qb58WNLC0heFoK-RuunVw6RSI4rYEoO32ll5lDH8-5WkfEQEGFmnqamnNrqTl6wqpaT3VhMVq3-In9y-JFtdRcDs4i0ry2e9swgO6_1lWAZmYcj_-1B2GWb3YRwnL6CECwgqy6v5na9_RXB7Q_at9wKIVcJYkvcby6hmkT3KrRKbIm2zyHwOuUm5aGCPhbMLUfc3kO5ZE9jV-sEzHv9uk4RltUTvpPnm1-j_A8BBQcA=

After screenshot:

image
image image
image

@Peechey Peechey added the enhancement New feature, calculation, or mod label May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Culling Strike to PoE 2 Implementation

1 participant