Repository navigation
feat: persist goals and reading activity with derived progress - #12
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91a1612a0c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace example goal/session responses with owned persisted goals and an immutable reading-activity ledger. Calendar-aware projections support books, reading time, pages, and reading days, with overlapping interval/coverage deduplication and retained rule/period history.
Tracking capability version 2 adds
book_idsfor goals scoped to multiple selected books. Validate every selected book's ownership for definitions and period snapshots, reject impossible books-finished targets, and preserve existing single-book payloads. Shared Dart/Python fixtures cover multi-book projection and eligible time after creation cutoffs and overlapping logs.Validation
Compatibility and delivery
Apply additive Alembic revision
b5c6d7e8f901, publication/grants, and PowerSync streams before releasing the integrated client. Advertisetracking_schema_version: 2; existing metric strings remain, with additivereading_days. Older clients can continue using single-book/library goals, while newer clients stage unsupported multi-book tracking on older servers.Versions remain unchanged; target
development. Coordinate client #40, reader #5, and workspace #13. Current Goals UI screenshots are embedded in the client PR.