Skip to content

feat: persist goals and reading activity with derived progress - #12

Merged
Eoic merged 3 commits into
developmentfrom
feat/goals-redesign
Oct 8, 2026
Merged

Eoic merged 3 commits into
developmentfrom
feat/goals-redesign

Conversation

@Eoic

@Eoic Eoic commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Summary

Replace example goal/session responses with owned persisted goals and an immutable reading-activity ledger. Calendar-aware projections support books, reading time, pages, and reading days, with overlapping interval/coverage deduplication and retained rule/period history.

Tracking capability version 2 adds book_ids for goals scoped to multiple selected books. Validate every selected book's ownership for definitions and period snapshots, reject impossible books-finished targets, and preserve existing single-book payloads. Shared Dart/Python fixtures cover multi-book projection and eligible time after creation cutoffs and overlapping logs.

Validation

  • Latest focused tracking service, goal route, and sync route run: 27 passed.
  • Ruff lint/format checks and strict Mypy passed.
  • Earlier migration tests preserve existing book data; the latest changes extend the JSON tracking payload and require no additional migration.
  • Live multi-device PowerSync transport remains unverified.

Compatibility and delivery

Apply additive Alembic revision b5c6d7e8f901, publication/grants, and PowerSync streams before releasing the integrated client. Advertise tracking_schema_version: 2; existing metric strings remain, with additive reading_days. Older clients can continue using single-book/library goals, while newer clients stage unsupported multi-book tracking on older servers.

Versions remain unchanged; target development. Coordinate client #40, reader #5, and workspace #13. Current Goals UI screenshots are embedded in the client PR.

Copilot AI balanced review requested due to automatic review settings October 6, 2026 14:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T14:30:08.261091Z 91a1612 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 91a1612a0c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread papyrus/services/tracking_validation.py Outdated
Comment thread papyrus/services/goals.py Outdated
Comment thread papyrus/services/goals.py
Comment thread papyrus/services/progress.py Outdated
Comment thread papyrus/services/progress.py Outdated
@Eoic Eoic self-assigned this Oct 7, 2026
@Eoic
Eoic merged commit de204be into development Oct 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants