Repository navigation
fix: check Linux packaging dependencies before release #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| name: Linux packaging check | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'app/linux/**' | ||
| - 'app/pubspec.yaml' | ||
| - 'app/pubspec.lock' | ||
| - 'tools/install_linux_build_dependencies.sh' | ||
| - '.github/workflows/release.yml' | ||
| - '.github/workflows/linux-packaging.yml' | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: linux-packaging-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| linux: | ||
| name: Compile Linux release | ||
| runs-on: ubuntu-24.04 | ||
| defaults: | ||
| run: | ||
| working-directory: app | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Install Linux dependencies | ||
| run: bash ../tools/install_linux_build_dependencies.sh | ||
| - uses: subosito/flutter-action@v2 | ||
| with: | ||
| flutter-version: '3.41.2' | ||
| cache: true | ||
| - name: Install locked dependencies | ||
| run: flutter pub get --enforce-lockfile | ||
| - name: Compile Linux release | ||
| run: flutter build linux --release | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| sudo apt-get update | ||
| sudo apt-get install -y \ | ||
| clang cmake ninja-build pkg-config \ | ||
| libgtk-3-dev libwebkit2gtk-4.1-dev libsecret-1-dev \ | ||
| liblzma-dev libstdc++-12-dev | ||
|
|
||
| pkg-config --print-errors --exists gtk+-3.0 webkit2gtk-4.1 libsecret-1 | ||
| pkg-config --print-errors --atleast-version=0.18.4 libsecret-1 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
Compile Linux releaseis configured as a required check, as the commit's testing notes prescribe, this workflow is never created for ordinary UI-only PRs because none of these paths match. GitHub leaves checks from path-filtered workflows pending, so those PRs will be blocked from merging rather than merely avoiding the Linux build (GitHub documentation). Trigger the workflow for every PR and conditionally skip only the expensive build job while ensuring the required check reports success.Useful? React with 👍 / 👎.