Skip to content

fix: check Linux packaging dependencies before release - #37

Merged
Eoic merged 2 commits into
masterfrom
fix/linux-packaging-check
Oct 5, 2026
Merged

Eoic merged 2 commits into
masterfrom
fix/linux-packaging-check

Conversation

@Eoic

@Eoic Eoic commented Oct 5, 2026

Copy link
Copy Markdown
Member

Summary

Linux release packaging fails because flutter_secure_storage_linux requires libsecret-1 >= 0.18.4. Install all current native plugin build dependencies through one shared script and use Ubuntu 24.04 for the release and verification jobs.

Add a focused PR Linux release compilation check for dependency manifests, native Linux files, and packaging workflow/script changes. This catches missing native libraries before attempting a multi-platform release, without adding this build to ordinary UI-only PRs. Release publication still triggers only on version changes or explicit manual retry.

Testing

  • Enumerated native plugin CMake requirements: GTK, WebKitGTK 4.1, and libsecret >= 0.18.4.
  • Actionlint, ShellCheck, Bash syntax, and git diff --check passed.
  • The new Compile Linux release PR check must pass before merging.

UI evidence

Not applicable.

Compatibility and migration

No application dependency/version changes. The existing 0.0.1+1 Android, web, and Windows builds have passed, and no client release tag or Play upload exists.

Notes

Merge after the Linux packaging check passes, then dispatch Release on master to publish the complete 0.0.1+1 release. The production API/web app are already healthy at version 0.0.1.

The packaging script is shared by the PR check and release build to keep their dependency lists aligned.

Copilot AI balanced review requested due to automatic review settings October 5, 2026 22:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T22:15:31.605647Z 4859eb1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4859eb1817

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +4 to +5
pull_request:
paths:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Do not path-filter the required packaging check

If Compile Linux release is configured as a required check, as the commit's testing notes prescribe, this workflow is never created for ordinary UI-only PRs because none of these paths match. GitHub leaves checks from path-filtered workflows pending, so those PRs will be blocked from merging rather than merely avoiding the Linux build (GitHub documentation). Trigger the workflow for every PR and conditionally skip only the expensive build job while ensuring the required check reports success.

Useful? React with 👍 / 👎.

@Eoic
Eoic merged commit b8363ea into master Oct 5, 2026
3 of 4 checks passed
@Eoic
Eoic deleted the fix/linux-packaging-check branch October 9, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants