Repository navigation
fix: check Linux packaging dependencies before release - #37
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4859eb1817
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pull_request: | ||
| paths: |
There was a problem hiding this comment.
Do not path-filter the required packaging check
If Compile Linux release is configured as a required check, as the commit's testing notes prescribe, this workflow is never created for ordinary UI-only PRs because none of these paths match. GitHub leaves checks from path-filtered workflows pending, so those PRs will be blocked from merging rather than merely avoiding the Linux build (GitHub documentation). Trigger the workflow for every PR and conditionally skip only the expensive build job while ensuring the required check reports success.
Useful? React with 👍 / 👎.
Summary
Linux release packaging fails because
flutter_secure_storage_linuxrequireslibsecret-1 >= 0.18.4. Install all current native plugin build dependencies through one shared script and use Ubuntu 24.04 for the release and verification jobs.Add a focused PR Linux release compilation check for dependency manifests, native Linux files, and packaging workflow/script changes. This catches missing native libraries before attempting a multi-platform release, without adding this build to ordinary UI-only PRs. Release publication still triggers only on version changes or explicit manual retry.
Testing
git diff --checkpassed.Compile Linux releasePR check must pass before merging.UI evidence
Not applicable.
Compatibility and migration
No application dependency/version changes. The existing
0.0.1+1Android, web, and Windows builds have passed, and no client release tag or Play upload exists.Notes
Merge after the Linux packaging check passes, then dispatch Release on
masterto publish the complete0.0.1+1release. The production API/web app are already healthy at version0.0.1.The packaging script is shared by the PR check and release build to keep their dependency lists aligned.