Repository navigation
server: add provider-admin recipient entities and CRUD - #98
Merged
Merged
Conversation
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
from
September 18, 2026 00:12
5aa09d2 to
66ec9b5
Compare
littlegrasscao
marked this pull request as ready for review
September 18, 2026 00:33
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
2 times, most recently
from
September 22, 2026 16:42
294e667 to
960f905
Compare
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
from
September 25, 2026 22:18
960f905 to
75bcb6d
Compare
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
from
September 25, 2026 22:27
75bcb6d to
d236608
Compare
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
from
September 25, 2026 22:32
d236608 to
b172143
Compare
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
from
September 25, 2026 22:37
b172143 to
a1ec6a8
Compare
zhu-tom
added this pull request to stack #111
October 1, 2026 18:55
littlegrasscao
removed this pull request from stack #111
October 1, 2026 20:19
littlegrasscao
added this pull request to stack #112
October 1, 2026 20:20
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
from
October 2, 2026 16:15
a1ec6a8 to
53e0056
Compare
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
from
October 2, 2026 16:40
53e0056 to
5477176
Compare
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
from
October 5, 2026 20:57
5477176 to
606cba6
Compare
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
from
October 5, 2026 21:25
606cba6 to
be8d758
Compare
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
from
October 5, 2026 23:59
be8d758 to
e925253
Compare
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
from
October 9, 2026 23:35
aa3ec7a to
4fb8356
Compare
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
from
October 13, 2026 23:35
4fb8356 to
372d96d
Compare
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
2 times, most recently
from
October 14, 2026 00:06
0d3c637 to
52bedce
Compare
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
from
October 14, 2026 00:56
52bedce to
1ced28e
Compare
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
from
October 14, 2026 19:24
1ced28e to
7e1dbc0
Compare
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
from
October 15, 2026 16:46
7e1dbc0 to
eed5e6a
Compare
zhu-tom
reviewed
Oct 15, 2026
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
2 times, most recently
from
October 15, 2026 23:38
1258223 to
3700fcf
Compare
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
from
October 16, 2026 00:40
3700fcf to
e84e796
Compare
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
from
October 19, 2026 17:12
e84e796 to
6fbf684
Compare
zhu-tom
approved these changes
Oct 19, 2026
littlegrasscao
force-pushed
the
server/split2/09-provider-recipients
branch
from
October 19, 2026 21:43
6fbf684 to
3b777dc
Compare
added 4 commits
October 21, 2026 10:04
…e recipient run one at a time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RecipientEntityandRecipientTokenEntitypersistence and the provider recipient API, served byRecipientAdminService:POST /recipients,GET /recipients,GET /recipients/{recipient},PATCH /recipients/{recipient},DELETE /recipients/{recipient}RecipientService.createcallscatalog.authorize(CREATE_RECIPIENT); the catalog'suserIdbecomes the owner, and only the owner may update or delete the recipientSELECT ... FOR UPDATE, so concurrent changes to one recipient run one at a time; an update that waits on a delete gets 404activationUrlserver.public-urlsetting, the address recipients reach the server at, rather than the address the provider's request arrived on, which can be internal to a proxy. The server fails to start without it, and it must be an http or https URLUSE_RECIPIENTwill applyTesting
mvn clean install: 100 tests passedRecipientServiceTest: creating a recipient requiresCREATE_RECIPIENTfrom the catalogRecipientAdminServiceTest: recipient CRUD over HTTP as the owner, case-insensitive gets, owner-only updates and deletes, and 401 without a token the catalog acceptsPublicUrlTest: startup fails withoutserver.public-url, invalid values are rejected, and activation links use the public URL rather than the request addressTestServersetsserver.public-urlto its own address;OpenSharingServerTestandUnknownRouteTestset one so the server starts