Repository navigation
protocol: generate temporary table credentials - #107
Draft
littlegrasscao wants to merge 1 commit into
Draft
littlegrasscao wants to merge 1 commit into
littlegrasscao wants to merge 1 commit into
Conversation
littlegrasscao
marked this pull request as ready for review
September 29, 2026 18:17
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
from
September 29, 2026 18:35
80beed7 to
beb1ff8
Compare
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
from
September 29, 2026 18:37
beb1ff8 to
2389898
Compare
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
5 times, most recently
from
October 1, 2026 18:44
6421801 to
d237282
Compare
littlegrasscao
marked this pull request as draft
October 7, 2026 01:57
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
from
October 14, 2026 01:36
d237282 to
9751671
Compare
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
from
October 14, 2026 02:07
9751671 to
d234d60
Compare
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
from
October 14, 2026 19:25
d234d60 to
4c2ab55
Compare
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
from
October 15, 2026 16:47
4c2ab55 to
0682423
Compare
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
from
October 15, 2026 18:14
0682423 to
eeb78ec
Compare
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
from
October 15, 2026 18:29
eeb78ec to
bdb6621
Compare
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
from
October 15, 2026 23:35
bdb6621 to
54af43d
Compare
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
from
October 15, 2026 23:38
54af43d to
7d5dd09
Compare
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
from
October 15, 2026 23:54
7d5dd09 to
c9038d7
Compare
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
from
October 16, 2026 00:18
c9038d7 to
86b684e
Compare
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
from
October 16, 2026 00:41
86b684e to
602b7f6
Compare
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
from
October 19, 2026 17:13
602b7f6 to
3e72ef7
Compare
zhu-tom
added this pull request to stack #116
October 19, 2026 19:06
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
from
October 19, 2026 21:44
3e72ef7 to
63c6d19
Compare
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
from
October 19, 2026 22:35
63c6d19 to
6ca73d7
Compare
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
from
October 19, 2026 22:37
6ca73d7 to
24596a8
Compare
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
2 times, most recently
from
October 21, 2026 17:01
a850517 to
4b6e00c
Compare
littlegrasscao
force-pushed
the
server/split2/17-protocol-table-credentials
branch
from
October 21, 2026 19:15
4b6e00c to
6e52ba9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /shares/{share}/schemas/{schema}/tables/{table}/temporary-table-credentialstoOpenSharingProtocolServicecredentialsJSON (awsTempCredentials/azureUserDelegationSas/gcpOauthToken/r2Credentials) for tables withdiraccesslocationmust be the table root or one of its auxiliary locationsCredentialRequest.ttlnull), rather than a new server settingStorageCredentials.covers(location)replaces the prefix check the kernel kept privatelyTesting
mvn clean install: 159 tests passedProtocolTableCredentialsTest: placeholder AWS credentials for the table root with no body, explicit root location, schema-grant child, malformed body, location outside the table, ungranted shareTemporaryCredentialsTestmaps AWS, Azure, GCP, and R2 credentialsStacked on #106.