Repository navigation
refactor: share ShipReached's reach with tools - #1218
Merged
Merged
Conversation
The editor's map rings each marker a ShipReached trigger watches, at the distance the game watches within. It kept its own copy of the 4000, since the engine's constant was private. Making it public lets the editor read it from OpenReliant, so the two can't drift apart.
vdmkenny
added a commit
to OpenReliant/openreliant-editor
that referenced
this pull request
Oct 15, 2026
Pins OpenReliant 0.17.0. The profile reads ShipReached's reach from it (`mission.events.reached_reach`, made public in OpenReliant/openreliant#1218) and drops its own copy of the 4000. `make check` passes, and `--check-missions` builds all 44 of the game's missions from source again as the same missions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reached_reach, how far ShipReached's watches look, becomes public, so that tools can read it rather than keep a copy.The editor's map rings each marker a ShipReached trigger watches at this distance, and keeps its own 4000 for now (OpenReliant/openreliant-editor#31). Once a release includes this, the editor reads
mission.events.reached_reachand drops its copy.One local test run had a failure in the platform tests' binary, which passed on every rerun, also with the same seed; this change doesn't touch them.