Repository navigation
Conversation
The catalogue was only read when GET MODS opened, so the mods screen couldn't tell that an installed mod had a newer version. With CHECK FOR UPDATES on, the mods screen now has the GET MODS screen read the repositories in the background as it opens, once per run, and a mod the catalogue offers in a newer version is gold in the list, with UPDATE AVAILABLE IN GET MODS in its panel. GET MODS opens on the chosen mod. The same switch as the release check keeps web access under one setting. Closes OpenReliant#1041
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mods screen now says which of its mods the catalogue offers in a newer version: the mod is gold in the list, and its panel says UPDATE AVAILABLE IN GET MODS with the version. The same rule as UPDATE on GET MODS decides it (
offeredFor, shared by both screens): not for a folder copied in by hand, nor for a mod that needs a newer OpenReliant. GET MODS, opened from the mods screen, chooses the mod the mods screen had chosen, unfolding its group.The mods screen reads nothing itself. It has the GET MODS screen read the repositories in the background as it opens, once per run (
readInBackground,continueReading), so there is one reader and one catalogue, kept until RELOAD. A reading GET MODS leaves behind goes on from the mods screen too.The switch. This makes the mods screen connect to the web, which only GET MODS did until now. I put it under the existing CHECK FOR UPDATES setting (
UpdateCheck,--no-update-check), so one switch covers everything OpenReliant checks for on its own: the release check and the mods' updates. Unticked, the mods screen reads nothing, but still shows what GET MODS has read. The docs say that the repository's server sees the player's address then, as GitHub does for the release check. Does sharing the switch suit you? The alternatives are a setting of its own for the mods, or no setting at all, reading whenever the settings file names a repository. I'm happy to change it to either.This branch is from
mainand doesn't include #1133 (CANCEL on GET MODS); both touchmod_catalogue.zig, so I'll rebase whichever goes second.Closes #1041