Conversation
The QEMU runner filled each FMC backing image with one byte, so a test could hand the device erased flash and nothing else. The integration test needs the device to already hold a firmware image the update agent can offer. cs0_contents and cs1_contents name a file to copy in at offset 0; the remainder stays 0xFF. Without them the fill byte behaves as before, so every existing test is unchanged. A contents file longer than flash_size is an error rather than a truncation. A half-written image still parses far enough to fail verification, which would make a verify-failure scenario pass for the wrong reason. Assisted-by: Claude
This was referenced Oct 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The QEMU runner filled each FMC backing image with a single byte, so a
test could only hand the device erased flash. A test that exercises the
update path needs the device to already hold a firmware image the update
agent can offer.
cs0_contents and cs1_contents name a file copied into the image at
offset 0; the rest stays 0xFF. Without them the fill byte behaves as
before, so flash_qemu_test and smc_read_qemu_test are unchanged.
A contents file longer than flash_size is an error rather than a
truncation. A half-written image still parses far enough to fail
verification, which would make a verify-failure scenario pass for the
wrong reason.
There is no in-tree consumer yet. This is the first of two pieces of
groundwork for a QEMU integration test driven by a software mock BMC:
a reset line, a boot-worked line, and a PLDM update agent. The builder
that makes the file is the follow-up.
Assisted-by: Claude