Skip to content

docs(release): correct optional npm handoff comment #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BunsDev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(release): correct optional npm handoff comment #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,17 +346,9 @@ jobs:
body_path: release-notes.md
files: release/*

# Explicit hand-off to npm-publish.yml.
#
# We can't rely solely on the `workflow_run` trigger in npm-publish.yml
# because this Release workflow is itself triggered by a workflow
# dispatch from auto-release.yml's GITHUB_TOKEN, and GitHub's
# automatic-token rules don't list `workflow_run` as an exception to
# the "events from GITHUB_TOKEN don't create new workflow runs" rule.
# In practice that means the workflow_run chain silently no-ops on
# auto-cut releases. Dispatching directly here makes the publish step
# deterministic — the workflow_run trigger stays as a manual-release
# fallback.
# npm-publish.yml is manual-only; there is no workflow_run fallback.
# Dispatch it explicitly only when publish_npm is true. The deprecated
# npm package is otherwise left untouched; releases ship GitHub binaries.
- name: Dispatch npm-publish.yml
if: ${{ inputs.publish_npm }}
env:
Expand Down
Loading