Skip to content

docs(release): correct optional npm handoff comment - #328

Open
BunsDev wants to merge 1 commit into
mainfrom
docs/npm-handoff-current-main
Open

BunsDev wants to merge 1 commit into
mainfrom
docs/npm-handoff-current-main

Conversation

@BunsDev

@BunsDev BunsDev commented Oct 16, 2026

Copy link
Copy Markdown
Member

Summary

  • Correct the release workflow comment to describe the actual optional npm dispatch.

Context

  • Related request: Goal 3 surface audit, manifest position 136 (logical unit 140).
  • Scope: release workflow documentation beside the npm handoff step.
  • Non-goals: changing release or npm publishing behavior.

Changes

  • Replace the stale workflow_run fallback explanation with the current manual-only npm workflow and publish_npm guard.

Validation

  • git diff --check — passed.
  • Focused assertion — failed on current main, passed after patch; confirms npm workflow is dispatch-only and release job is guarded by publish_npm.
  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/release.yml")' — passed.
  • cargo fmt --all -- --check — passed.
  • cargo check --workspace --all-targets --locked — passed.
  • cargo clippy --workspace --all-targets --locked -- -D warnings — passed.
  • cargo test --workspace --locked — passed, 2,667 tests passed, 0 failed, 38 ignored across 107 groups.
  • TUI suite — N/A; no TUI or input changes.

PR Readiness

  • Diff is limited to the intended workflow comment.
  • Generated files were not edited by hand.
  • User-facing docs/help are not needed; workflow comment corrected.
  • No secrets, credentials, local paths, or unrelated logs are included.
  • Remaining risk: hosted CI and independent review are pending; merge remains held until v0.9.0 exists.

@vercel

vercel Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 16, 2026 5:03am UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — bd55c9e8 Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant