Repository navigation
build(openccu-base): migrate patch 0057 - #4631
Merged
Merged
Conversation
jens-maus
added
🏷️ OCCU
Claude
This was referenced Nov 2, 2026
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Base pin and migration records buildroot-external/package/openccu-base/openccu-base.mk, buildroot-external/package/openccu-base/openccu-base.hash, docs/base-patch-migration/* |
The package pin and source checksum change. Migration patch hashes and migration state are updated. |
Firmware presentation and window naming buildroot-external/package/openccu-base/rootfs-patches/0001-OpenCCU.patch, buildroot-external/package/openccu-base/rootfs-patches/0031-WebUI-Fix-FileUpload.patch |
The version display and update check use OpenCCU values and assets. The WebUI sets the current window name to ccu-main-window. |
Per-interface duty-cycle display buildroot-external/package/openccu-base/rootfs-patches/{0001-OpenCCU,0031-WebUI-Fix-FileUpload,0039-WebUI-Fix-Style-Glitches,0046-WebUI-ImprovedScriptEditor,0054-WebUI-AddTimeZones}* |
Duty-cycle refresh uses Interface.getDutyCycle for returned interfaces and displays valid duty-cycle and carrier-sense values. It discards stale responses and hides unavailable rows. Associated progress-bar styles are removed and parting-line styling is added. |
Timezone offset handling buildroot-external/package/openccu-base/rootfs-patches/0054-WebUI-AddTimeZones.patch |
Position updates use the returned UTC offsets instead of translating timezone abbreviations. The all-device update uses the argument-free setter and retains its retry behavior. |
WebUI layout adjustments buildroot-external/package/openccu-base/rootfs-patches/0039-WebUI-Fix-Style-Glitches* |
The patch changes layout, overflow, table, control, dialog, and image-preview styling across WebUI pages. |
CodeMirror script editor buildroot-external/package/openccu-base/rootfs-patches/0046-WebUI-ImprovedScriptEditor.patch |
The script editor uses CodeMirror input and output. Script execution checks syntax before running, and editor dialogs use screen-relative sizing. |
Remove standalone duty-cycle patch buildroot-external/package/openccu-base/rootfs-patches/0057-WebUI-ImprovedDutyCycleDisplay*, buildroot-external/package/openccu-base/rootfs-patches/series |
The 0057 patch and its series entry are removed, along with its API registry, endpoint, start-page template, and stylesheet. |
Estimated code review effort: 4 (Complex) | ~45 minutes
Change: Other
Possibly related issues
- OpenCCU-Base patch migration: deferred findings and open items #4361: Tracks migration status for rootfs patches and lists the 0057 duty-cycle patch, which this PR removes from the patch series.
Possibly related PRs
- OpenCCU/OpenCCU#4628: This PR records the completion of the preceding patch migration and advances the OpenCCU-Base pin.
- OpenCCU/OpenCCU#4541: This PR changes content and patch handling for 0057, which this PR removes after migrating its duty-cycle implementation.
Suggested labels: dependencies
Merge Risk: 
c921a
-
No issue introduced by this change remains identified. Merge after the normal checks.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely identifies the main change: migrating patch 0057 for openccu-base. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (16 skipped: 11 unsupported, 5 too large.)
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes OpenCCU rootfs patch 0057-WebUI-ImprovedDutyCycleDisplay.patch, now that OpenCCU/OpenCCU-Base#293 is merged.
OpenCCU-Base merge commit:
62753fc9320fb0c5122daab36f4f08c26902160d(OpenCCU/OpenCCU-Base#293, the current OpenCCU-Base HEAD). Between the previous pin01e40077(set by #4628) and this merge commit, OpenCCU-Base also merged OpenCCU/OpenCCU-Base#294 (98c9cd1d, a version for every program and library). The new pin includes this unrelated change; it does not touch any patched rootfs file, the license files or theeq3_char_loopsource.The Base change includes the fixes of the source patch made before the migration: #4629 (stale rows, disconnected gateways, documented API response, carrier sense
aria-valuenow, hidden separator, superseded responses; the atomic and logged write of/tmp/dutycycle.jsonbyupdateDCVars.tclstays in OpenCCU).Changes:
docs/base-patch-migration/state.jsonand refreshes the verified checkpoint to the pin of build(openccu-base): migrate patch 0183 #4628 (01e40077).62753fc9320fb0c5122daab36f4f08c26902160d(merge commit of webui: show the duty cycle and carrier sense of all gateways on the start page OpenCCU-Base#293).git4archive hash to0de798c9f9847b11943132dc9cbd289474ce1c0f97b720ec1e8e190863bae9f7.Workspace refresh
update_patchfiles.shagainst the pristine rootfs of the new pin refreshed the workspaces of the earlier patches 0001, 0031 and 0054 (webui.js) and 0039 and 0046 (webui.js,style.css). Each.orig/new pair gains exactly the Base change (7 pairs checked), and the generated patches only change hunk line numbers. The later workspaces 0061, 0097, 0109 and 0154 already contained the 0057 changes and stay unchanged.git diff --checkis clean.The remaining rootfs patch count is 14.
Validation
git4archive regenerated with Buildroot 2026.08.1's download tooling;prepare-cleanup 0057with the merge receipt of webui: show the duty cycle and carrier sense of all gateways on the start page OpenCCU-Base#293.create_patches.sh --check: clean.base-patch-migration.py index: PASS (14 patches). The migration unit tests passed.validateagainst the new pin, before and after the workspace refresh: PASS. All 14 patches apply with zero fuzz; the patched rootfs is identical before and after the refresh.comparewith the validation of the state of fix(webui): hide duty cycle rows of interfaces missing from the update #4629 (pin01e40077, 15 patches): IDENTICAL (all 4667 manifest entries, transitioncleanup-removalof 0057).Generated by Claude Code
Summary by CodeRabbit