Skip to content

chore: [SDK-5634] add extra IAM type buttons to demo app - #1787

Merged
fadi-george merged 2 commits into
mainfrom
fadi/sdk-5634
Oct 29, 2026
Merged

fadi-george merged 2 commits into
mainfrom
fadi/sdk-5634

Conversation

@fadi-george

@fadi-george fadi-george commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Description

One Line Summary

Adds HTML, Full Bleed, Carousel, and Carousel Bleed IAM buttons to the iOS demo app and lays out all 8 in a 2-column grid.
Screenshot 2026-10-29 at 12 15 01 PM

Details

Motivation

Lets us test the extra IAM layouts from the demo app. Follows the shared spec update in OneSignal/sdk-shared#66.

Scope

  • InAppMessageType: 4 new cases (html, full_bleed, carousel, carousel_bleed), shorter labels (Top, Bottom, Center, HTML, Full, Full Bleed, Carousel, Carousel Bleed), and an order that pairs them in the grid. Existing iam_type values and accessibility IDs are unchanged.
  • SendIamSection: buttons are in a 2-column LazyVGrid.
  • ActionButton: minimumScaleFactor(0.7) plus 8pt side padding, so long labels shrink instead of being cut off. Labels that already fit are unchanged.
  • Demo app only. No SDK changes.

Testing

Manual testing

Built the App scheme for iOS Simulator and ran swiftlint (no new warnings). Checked the grid layout (before the label rename) and the Carousel IAM on an iPad simulator. Final labels not yet checked on device.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed (demo app UI only)
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

🤖 Generated with Claude Code

fadi-george and others added 2 commits October 29, 2026 11:26
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…bels

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants